From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Alexandre Ferrieux <alexandre.ferrieux@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
alexandre.ferrieux@orange.com,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Simon Horman <horms@verge.net.au>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net v6] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.
Date: Wed, 13 Nov 2024 16:41:10 -0800 [thread overview]
Message-ID: <20241113164110.196f491d@kernel.org> (raw)
In-Reply-To: <CAM0EoM=V80Qj3NQEcS4cmLoByTnUDn9BER8SWkWKUEp+OVRXWA@mail.gmail.com>
On Wed, 13 Nov 2024 09:17:09 -0500 Jamal Hadi Salim wrote:
> > Co-posting selftests
> > --------------------
> >
> > Selftests should be part of the same series as the code changes.
> > Specifically for fixes both code change and related test should go into
> > the same tree (the tests may lack a Fixes tag, which is expected).
> > Mixing code changes and test changes in a single commit is discouraged.
>
> Just the last sentence:
> Mixing unrelated (to the fix) code changes and test changes in a
> single commit is discouraged.
Perfect example why things are not documented.
I have no idea what you're trying to say..
I think you're the only person who is getting this wrong,
so I'll toss the documentation patch.
prev parent reply other threads:[~2024-11-14 0:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 14:11 [PATCH net v6] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes Alexandre Ferrieux
2024-11-09 12:50 ` Jamal Hadi Salim
2024-11-09 15:39 ` Alexandre Ferrieux
2024-11-11 18:26 ` Jakub Kicinski
2024-11-12 12:23 ` Jamal Hadi Salim
2024-11-12 13:48 ` Alexandre Ferrieux
2024-11-12 15:18 ` Jakub Kicinski
2024-11-12 17:07 ` Jamal Hadi Salim
2024-11-13 1:57 ` Jakub Kicinski
2024-11-13 10:12 ` Alexandre Ferrieux
2024-11-13 14:17 ` Jamal Hadi Salim
2024-11-14 0:41 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113164110.196f491d@kernel.org \
--to=kuba@kernel.org \
--cc=alexandre.ferrieux@gmail.com \
--cc=alexandre.ferrieux@orange.com \
--cc=andrew@lunn.ch \
--cc=edumazet@google.com \
--cc=horms@verge.net.au \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).