From: Jakub Kicinski <kuba@kernel.org>
To: Michal Luczaj <mhal@rbox.co>
Cc: Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: Make copy_safe_from_sockptr() match documentation
Date: Thu, 14 Nov 2024 17:57:11 -0800 [thread overview]
Message-ID: <20241114175711.1a51c414@kernel.org> (raw)
In-Reply-To: <535b4ef7-3cfb-4816-bd7e-c0fa8725c7f8@rbox.co>
On Fri, 15 Nov 2024 00:36:35 +0100 Michal Luczaj wrote:
> > I'll move this to the commit message, it's important.
> >
> > Are you planning to scan callers of copy_from_sockptr() ?
> > I looked at 3 callers who save the return value, 2 of them are buggy :S
>
> Sure, I took a look:
> https://lore.kernel.org/netdev/20241115-sockptr-copy-fixes-v1-0-d183c87fcbd5@rbox.co/
> Have I missed anything?
Looks like you covered the two I spotted - rxrpc and llc, thanks!
next prev parent reply other threads:[~2024-11-15 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-10 23:17 [PATCH net] net: Make copy_safe_from_sockptr() match documentation Michal Luczaj
2024-11-14 3:29 ` Jakub Kicinski
2024-11-14 23:36 ` Michal Luczaj
2024-11-15 1:57 ` Jakub Kicinski [this message]
2024-11-14 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114175711.1a51c414@kernel.org \
--to=kuba@kernel.org \
--cc=edumazet@google.com \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).