From: Jakub Kicinski <kuba@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: ttoukan.linux@gmail.com, gal@nvidia.com, saeedm@nvidia.com,
tariqt@nvidia.com, leon@kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors
Date: Thu, 14 Nov 2024 18:27:50 -0800 [thread overview]
Message-ID: <20241114182750.0678f9ed@kernel.org> (raw)
In-Reply-To: <20241114021711.5691-1-laoar.shao@gmail.com>
On Thu, 14 Nov 2024 10:17:11 +0800 Yafang Shao wrote:
> - * Not recommended for use in drivers for high speed interfaces.
I thought I suggested we provide clear guidance on this counter being
related to processing pipeline being to slow, vs host backpressure.
Just deleting the line that says "don't use" is not going to cut it :|
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-15 2:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 2:17 [PATCH v2 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors Yafang Shao
2024-11-15 2:27 ` Jakub Kicinski [this message]
2024-11-15 3:56 ` Yafang Shao
2024-11-15 4:32 ` Jakub Kicinski
2024-11-15 5:50 ` Yafang Shao
2024-11-15 8:01 ` Saeed Mahameed
2024-11-15 19:24 ` Jakub Kicinski
2024-11-15 19:54 ` Saeed Mahameed
2024-11-15 21:25 ` Jakub Kicinski
2024-11-15 22:09 ` Saeed Mahameed
2024-11-15 22:42 ` Jakub Kicinski
2024-11-20 6:04 ` Gal Pressman
2024-11-24 2:50 ` Jakub Kicinski
2024-11-17 6:33 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114182750.0678f9ed@kernel.org \
--to=kuba@kernel.org \
--cc=gal@nvidia.com \
--cc=laoar.shao@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).