From: Jakub Kicinski <kuba@kernel.org>
To: Qingtao Cao <qingtao.cao.au@gmail.com>
Cc: Qingtao Cao <qingtao.cao@digi.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v0 1/1] net: mv643xx_eth: disable IP tx checksum with jumbo frames for Armada 310
Date: Thu, 14 Nov 2024 19:24:59 -0800 [thread overview]
Message-ID: <20241114192459.75e5b4d9@kernel.org> (raw)
In-Reply-To: <20241113110040.24181-1-qingtao.cao@digi.com>
On Wed, 13 Nov 2024 21:00:40 +1000 Qingtao Cao wrote:
> The Ethernet controller found in Armada 310 doesn't support TCP/IP checksum
> with frame sizes larger than its TX checksum offload limit
>
> Disable the features NETIF_F_IP_CSUM and NETIF_F_TSO when the MTU is set to
> a value larger than this limit, to prevent the software TSO generating GSO
> packets that are not suitable to offload to the Ethernet controller, which
> would be calculated by the IP stack instead.
Did you consider disabling it per packet using .ndo_features_check ?
prev parent reply other threads:[~2024-11-15 3:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:00 [PATCH net-next v0 1/1] net: mv643xx_eth: disable IP tx checksum with jumbo frames for Armada 310 Qingtao Cao
2024-11-15 3:24 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114192459.75e5b4d9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qingtao.cao.au@gmail.com \
--cc=qingtao.cao@digi.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).