From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeedm@nvidia.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
ttoukan.linux@gmail.com, gal@nvidia.com, tariqt@nvidia.com,
leon@kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors
Date: Fri, 15 Nov 2024 11:24:43 -0800 [thread overview]
Message-ID: <20241115112443.197c6c4e@kernel.org> (raw)
In-Reply-To: <Zzb_7hXRPgYMACb9@x130>
On Fri, 15 Nov 2024 00:01:50 -0800 Saeed Mahameed wrote:
> not rx_missed_errors please, it is exclusive for software lack of buffers.
>
> Please have a look at thtool_eth_XXX_stats IEEE ethnl_stats, if you need to
> extend, this is the place.
>
> RFC2863[1] defines this type of discards as ifInDiscards. So let's add
> it to ehttool std stats. mlx5 reports most of them already to driver custom
> ethtool -S
We can, but honestly I'd just make sure they are counted in rx_dropped
and leave the detailed breakdown in ethtool -S. The value of the common
stats kicks in when we have multiple NICs with reasonably similar
interpretations. Hopefully for missed we do have that interpretation.
Anything further down in the pipeline will be device specific.
Or at least I haven't figured out sufficient commonalities among
the devices I deal with in production..
next prev parent reply other threads:[~2024-11-15 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 2:17 [PATCH v2 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors Yafang Shao
2024-11-15 2:27 ` Jakub Kicinski
2024-11-15 3:56 ` Yafang Shao
2024-11-15 4:32 ` Jakub Kicinski
2024-11-15 5:50 ` Yafang Shao
2024-11-15 8:01 ` Saeed Mahameed
2024-11-15 19:24 ` Jakub Kicinski [this message]
2024-11-15 19:54 ` Saeed Mahameed
2024-11-15 21:25 ` Jakub Kicinski
2024-11-15 22:09 ` Saeed Mahameed
2024-11-15 22:42 ` Jakub Kicinski
2024-11-20 6:04 ` Gal Pressman
2024-11-24 2:50 ` Jakub Kicinski
2024-11-17 6:33 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115112443.197c6c4e@kernel.org \
--to=kuba@kernel.org \
--cc=gal@nvidia.com \
--cc=laoar.shao@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).