From: Jakub Kicinski <kuba@kernel.org>
To: <bhelgaas@google.com>
Cc: Wei Huang <wei.huang2@amd.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<helgaas@kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<asml.silence@gmail.com>, <almasrymina@google.com>,
<gospo@broadcom.com>, <michael.chan@broadcom.com>,
<ajit.khaparde@broadcom.com>, <somnath.kotur@broadcom.com>,
<andrew.gospodarek@broadcom.com>, <manoj.panicker2@amd.com>,
<Eric.VanTassell@amd.com>
Subject: Re: [PATCH V1 1/2] bnxt_en: Add TPH support in BNXT driver
Date: Fri, 15 Nov 2024 14:04:34 -0800 [thread overview]
Message-ID: <20241115140434.50457691@kernel.org> (raw)
In-Reply-To: <20241115200412.1340286-2-wei.huang2@amd.com>
On Fri, 15 Nov 2024 14:04:11 -0600 Wei Huang wrote:
> +static void bnxt_irq_affinity_release(struct kref __always_unused *ref)
unused? you're using it now
> +{
> + struct irq_affinity_notify *notify =
> + (struct irq_affinity_notify *)
> + container_of(ref, struct irq_affinity_notify, kref);
this is ugly, and cast is unnecessary.
> + struct bnxt_irq *irq;
> +
> + irq = container_of(notify, struct bnxt_irq, affinity_notify);
since you init irq out of line you can as well init notify here
> + if (pcie_tph_set_st_entry(irq->bp->pdev, irq->msix_nr, 0)) {
You checked this function can sleep, right? Because rtnl_lock()
will sleep.
Bjorn, do you have a strong preference to have a user of the TPH code
merged as part of 6.13? We're very close to the merge window, I'm not
sure build bots etc. will have enough time to hammer this code.
My weak preference would be to punt these driver changes to 6.14
avoid all the conflicts and risks (unless Linus gives us another week.)
--
pw-bot: nap
next prev parent reply other threads:[~2024-11-15 22:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 20:04 [PATCH V1 0/2] Enable TPH support in BNXT driver Wei Huang
2024-11-15 20:04 ` [PATCH V1 1/2] bnxt_en: Add " Wei Huang
2024-11-15 22:04 ` Jakub Kicinski [this message]
2024-11-15 22:19 ` Michael Chan
2024-11-15 22:20 ` Bjorn Helgaas
2024-11-15 22:28 ` Andy Gospodarek
2025-01-08 11:33 ` Jiri Slaby
2025-01-09 19:09 ` Wei Huang
2025-01-09 19:17 ` Michael Chan
2024-11-15 20:04 ` [PATCH V1 2/2] bnxt_en: Pass NQ ID to the FW when allocating RX/RX AGG rings Wei Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241115140434.50457691@kernel.org \
--to=kuba@kernel.org \
--cc=Eric.VanTassell@amd.com \
--cc=ajit.khaparde@broadcom.com \
--cc=almasrymina@google.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=asml.silence@gmail.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manoj.panicker2@amd.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).