Re: [PATCH v2 11/21] scsi: arcmsr: Convert timeouts to secs_to_jiffies()

[kernel test robot <lkp@intel.com>]

Hi Easwar,

kernel test robot noticed the following build errors:

[auto build test ERROR on 2d5404caa8c7bb5c4e0435f94b28834ae5456623]

url:    https://github.com/intel-lab-lkp/linux/commits/Easwar-Hariharan/netfilter-conntrack-Cleanup-timeout-definitions/20241117-003530
base:   2d5404caa8c7bb5c4e0435f94b28834ae5456623
patch link:    https://lore.kernel.org/r/20241115-converge-secs-to-jiffies-v2-11-911fb7595e79%40linux.microsoft.com
patch subject: [PATCH v2 11/21] scsi: arcmsr: Convert timeouts to secs_to_jiffies()
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241118/202411180001.cZ0sTVB8-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241118/202411180001.cZ0sTVB8-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411180001.cZ0sTVB8-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/scsi/arcmsr/arcmsr_hba.c:56:
   In file included from include/linux/dma-mapping.h:11:
   In file included from include/linux/scatterlist.h:8:
   In file included from include/linux/mm.h:2213:
   include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     504 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     505 |                            item];
         |                            ~~~~
   include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     511 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     512 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
     524 |         return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~ ^
     525 |                            NR_VM_NUMA_EVENT_ITEMS +
         |                            ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/scsi/arcmsr/arcmsr_hba.c:1047:42: error: call to undeclared function 'secs_to_jiffies'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    1047 |         pacb->refresh_timer.expires = jiffies + secs_to_jiffies(60);
         |                                                 ^
   drivers/scsi/arcmsr/arcmsr_hba.c:1057:34: warning: shift count >= width of type [-Wshift-count-overflow]
    1057 |                     dma_set_mask(&pcidev->dev, DMA_BIT_MASK(64)))
         |                                                ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:77:54: note: expanded from macro 'DMA_BIT_MASK'
      77 | #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
         |                                                      ^ ~~~
   drivers/scsi/arcmsr/arcmsr_hba.c:1061:43: warning: shift count >= width of type [-Wshift-count-overflow]
    1061 |                 if (dma_set_coherent_mask(&pcidev->dev, DMA_BIT_MASK(64)) ||
         |                                                         ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:77:54: note: expanded from macro 'DMA_BIT_MASK'
      77 | #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
         |                                                      ^ ~~~
   drivers/scsi/arcmsr/arcmsr_hba.c:1062:47: warning: shift count >= width of type [-Wshift-count-overflow]
    1062 |                     dma_set_mask_and_coherent(&pcidev->dev, DMA_BIT_MASK(64))) {
         |                                                             ^~~~~~~~~~~~~~~~
   include/linux/dma-mapping.h:77:54: note: expanded from macro 'DMA_BIT_MASK'
      77 | #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
         |                                                      ^ ~~~
   7 warnings and 1 error generated.


vim +/secs_to_jiffies +1047 drivers/scsi/arcmsr/arcmsr_hba.c

  1043	
  1044	static void arcmsr_init_set_datetime_timer(struct AdapterControlBlock *pacb)
  1045	{
  1046		timer_setup(&pacb->refresh_timer, arcmsr_set_iop_datetime, 0);
> 1047		pacb->refresh_timer.expires = jiffies + secs_to_jiffies(60);
  1048		add_timer(&pacb->refresh_timer);
  1049	}
  1050	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki