From: Jakub Kicinski <kuba@kernel.org>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: wojackbb@gmail.com, netdev@vger.kernel.org,
chandrashekar.devegowda@intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com,
loic.poulain@linaro.org, johannes@sipsolutions.net,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com
Subject: Re: [net-next,v2] [PATCH net-next v2] net: wwan: t7xx: Change PM_AUTOSUSPEND_MS to 5000
Date: Mon, 18 Nov 2024 17:44:56 -0800 [thread overview]
Message-ID: <20241118174456.463c2817@kernel.org> (raw)
In-Reply-To: <7e5e2bda-e80d-46ec-816a-613c5808222e@gmail.com>
On Tue, 19 Nov 2024 03:01:47 +0200 Sergey Ryazanov wrote:
> > He's decreasing the sleep timer from 20 to 5 sec, both of which
> > are very high for networking, anyway. You appear to be questioning
> > autosuspend itself but it seems to have been added 2 years ago already.
> >
> > What am I missing?
>
> Some possible funny side-effect of sleeping with this chipset. Like
> loosing network connection and dropping TCP sessions. I hope that 20
> seconds was putted on purpose.
>
> Suddenly, I don't have this modem at hand and want to be sure that we
> are not going to receive a stream of bug reports.
Power saving is always tricky, but they say they tested. I think we
should give it a go, worst case - it will be an easy revert.
next prev parent reply other threads:[~2024-11-19 1:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 10:20 [net-next,v2] [PATCH net-next v2] net: wwan: t7xx: Change PM_AUTOSUSPEND_MS to 5000 wojackbb
2024-11-14 15:33 ` Andrew Lunn
2024-11-14 18:54 ` Sergey Ryazanov
2024-11-15 23:21 ` Jakub Kicinski
2024-11-19 1:01 ` Sergey Ryazanov
2024-11-19 1:44 ` Jakub Kicinski [this message]
2024-11-19 1:50 ` Sergey Ryazanov
2024-11-19 2:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118174456.463c2817@kernel.org \
--to=kuba@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=wojackbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).