From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
maxime.chevallier@bootlin.com,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCHv2 net-next 2/6] net: gianfar: use devm for register_netdev
Date: Mon, 18 Nov 2024 13:27:11 -0800 [thread overview]
Message-ID: <20241118212715.10808-3-rosenp@gmail.com> (raw)
In-Reply-To: <20241118212715.10808-1-rosenp@gmail.com>
Avoid manual unregister of netdev.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/freescale/gianfar.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
index e486b77bc6f4..9ff756130ba8 100644
--- a/drivers/net/ethernet/freescale/gianfar.c
+++ b/drivers/net/ethernet/freescale/gianfar.c
@@ -3305,7 +3305,7 @@ static int gfar_probe(struct platform_device *ofdev)
/* Carrier starts down, phylib will bring it up */
netif_carrier_off(dev);
- err = register_netdev(dev);
+ err = devm_register_netdev(&ofdev->dev, dev);
if (err) {
pr_err("%s: Cannot register net device, aborting\n", dev->name);
@@ -3374,8 +3374,6 @@ static void gfar_remove(struct platform_device *ofdev)
of_node_put(priv->phy_node);
of_node_put(priv->tbi_node);
- unregister_netdev(priv->ndev);
-
if (of_phy_is_fixed_link(np))
of_phy_deregister_fixed_link(np);
--
2.47.0
next prev parent reply other threads:[~2024-11-18 21:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 21:27 [PATCHv2 net-next 0/6] gianfar cleanups Rosen Penev
2024-11-18 21:27 ` [PATCHv2 net-next 1/6] net: gianfar: use devm_alloc_etherdev_mqs Rosen Penev
2024-11-18 21:27 ` Rosen Penev [this message]
2024-11-18 21:27 ` [PATCHv2 net-next 3/6] net: gianfar: assign ofdev to priv struct Rosen Penev
2024-11-18 21:27 ` [PATCHv2 net-next 4/6] net: gianfar: remove free_gfar_dev Rosen Penev
2024-11-18 21:27 ` [PATCHv2 net-next 5/6] net: gianfar: alloc queues with devm Rosen Penev
2024-11-18 21:27 ` [PATCHv2 net-next 6/6] net: gianfar: iomap " Rosen Penev
2024-11-18 21:41 ` [PATCHv2 net-next 0/6] gianfar cleanups Joe Damato
2024-11-18 21:45 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241118212715.10808-3-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).