From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A24A189BBA; Fri, 22 Nov 2024 23:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732317038; cv=none; b=o4l11n/hopOLhDSqFcVsrL/s+oZpiTelDI1BNb93mGb0htSRaotis8IomefVTbcQZp6ltqxowtHcfOmtOx+bG40kblR//+0fnmlbCJ9P8/Yg84l8kSryRzRjSt4XZGiON7yIBHeeIEAiFF+uIn+SATDZTQpnH57l/snSF371wyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732317038; c=relaxed/simple; bh=rg4KHNnnEeVTWVIVzYwlcPs/NM4nUdpeTimePX7r2nY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rJPw/kmwfUrCXb3sOIcp7VzDSzDC20HjQXGqjWneQ8xjtN1+0spTf6xdDcI1e7jZJ538waWzfv67V5LSka1qS7OEFNUGWDAfBSnk6OJy0fHYfnEQe51lePee5g/qnTf/P6T6d482GTw63ljfuFyyZ+TaesROau/EBcQSqmdzoNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PtxtB+0L; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PtxtB+0L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732317038; x=1763853038; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=rg4KHNnnEeVTWVIVzYwlcPs/NM4nUdpeTimePX7r2nY=; b=PtxtB+0L+e6oHfXKWxguG7vLA7ElAPQvfxnSkdbEOmg52QX7noFvXit3 vCLBFGDHNDM78q13jIt1ZdPmNgrlG6Bq7vZNpOsXXOjt2tz1pRqmhBlFW L6GFiQhCc6KAIM6ef2GL5dVcZ4Nm6ZxXoLr5SwvGKWW2TVdAkP/60IYMY wuxoCHVKdjwZwZOsSV0olTvhExAwIHFVKOROVdxfwPaIOEjTsPU70zzDx h425rVkGdi7at3JF/C9EOJlixc9K23GTyrWePf23vfhZDM1LNjGOY9TwF VY27eHrGAmHmRMAxn6vLa0LbRE+uWTaWwjNUi7vqIl6w/45TlEctmmb2I A==; X-CSE-ConnectionGUID: zzOyAFecSKeZclkqaaTgIg== X-CSE-MsgGUID: YDdPoVk/RNyOhoHA+Ym10Q== X-IronPort-AV: E=McAfee;i="6700,10204,11264"; a="32228175" X-IronPort-AV: E=Sophos;i="6.12,177,1728975600"; d="scan'208";a="32228175" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2024 15:10:37 -0800 X-CSE-ConnectionGUID: nyI02MZhRs+DyRbiVgIqBQ== X-CSE-MsgGUID: ppn41E5DQyqo46xwD3yX1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,177,1728975600"; d="scan'208";a="91063475" Received: from lkp-server01.sh.intel.com (HELO 8122d2fc1967) ([10.239.97.150]) by fmviesa010.fm.intel.com with ESMTP; 22 Nov 2024 15:10:30 -0800 Received: from kbuild by 8122d2fc1967 with local (Exim 4.96) (envelope-from ) id 1tEcnE-0004H1-2W; Fri, 22 Nov 2024 23:10:28 +0000 Date: Sat, 23 Nov 2024 07:10:04 +0800 From: kernel test robot To: Ming Yu , tmyu0@nuvoton.com, lee@kernel.org, linus.walleij@linaro.org, brgl@bgdev.pl, andi.shyti@kernel.org, mkl@pengutronix.de, mailhol.vincent@wanadoo.fr, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, wim@linux-watchdog.org, linux@roeck-us.net, jdelvare@suse.com, alexandre.belloni@bootlin.com Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v2 6/7] hwmon: Add Nuvoton NCT6694 HWMON support Message-ID: <202411230620.ncqamorB-lkp@intel.com> References: <20241121064046.3724726-7-tmyu0@nuvoton.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241121064046.3724726-7-tmyu0@nuvoton.com> Hi Ming, kernel test robot noticed the following build errors: [auto build test ERROR on andi-shyti/i2c/i2c-host] [also build test ERROR on mkl-can-next/testing groeck-staging/hwmon-next abelloni/rtc-next linus/master lee-mfd/for-mfd-fixes v6.12 next-20241122] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Ming-Yu/mfd-Add-core-driver-for-Nuvoton-NCT6694/20241121-155723 base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host patch link: https://lore.kernel.org/r/20241121064046.3724726-7-tmyu0%40nuvoton.com patch subject: [PATCH v2 6/7] hwmon: Add Nuvoton NCT6694 HWMON support config: hexagon-randconfig-r131-20241122 (https://download.01.org/0day-ci/archive/20241123/202411230620.ncqamorB-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce: (https://download.01.org/0day-ci/archive/20241123/202411230620.ncqamorB-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202411230620.ncqamorB-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/hwmon/nct6694-hwmon.c:263:15: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] frac_part = FIELD_GET(NCT6694_LSB_REG_MASK, data->xmit_buf[1]); ^ >> drivers/hwmon/nct6694-hwmon.c:508:10: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] FIELD_PREP(NCT6694_TIN_HYST_MASK, temp_hyst); ^ 2 errors generated. vim +/FIELD_GET +263 drivers/hwmon/nct6694-hwmon.c 238 239 static int nct6694_temp_read(struct device *dev, u32 attr, int channel, 240 long *val) 241 { 242 struct nct6694_hwmon_data *data = dev_get_drvdata(dev); 243 unsigned char temp_en, temp_hyst; 244 int ret, int_part, frac_part; 245 signed char temp_max; 246 247 guard(mutex)(&data->lock); 248 249 switch (attr) { 250 case hwmon_temp_enable: 251 temp_en = data->hwmon_en[NCT6694_TIN_EN(channel / 8)]; 252 *val = temp_en & BIT(channel % 8) ? 1 : 0; 253 254 return 0; 255 case hwmon_temp_input: 256 ret = nct6694_read_msg(data->nct6694, NCT6694_RPT_MOD, 257 NCT6694_TIN_IDX(channel), 2, 258 data->xmit_buf); 259 if (ret) 260 return ret; 261 262 int_part = sign_extend32(data->xmit_buf[0], 7); > 263 frac_part = FIELD_GET(NCT6694_LSB_REG_MASK, data->xmit_buf[1]); 264 if (int_part < 0) 265 *val = (int_part + 1) * 1000 - (8 - frac_part) * 125; 266 else 267 *val = int_part * 1000 + frac_part * 125; 268 269 return 0; 270 case hwmon_temp_max: 271 ret = nct6694_read_msg(data->nct6694, NCT6694_HWMON_MOD, 272 NCT6694_HWMON_CMD2_OFFSET, 273 NCT6694_HWMON_CMD2_LEN, 274 data->xmit_buf); 275 if (ret) 276 return ret; 277 278 *val = temp_from_reg(data->xmit_buf[NCT6694_TIN_HL(channel)]); 279 280 return 0; 281 case hwmon_temp_max_hyst: 282 ret = nct6694_read_msg(data->nct6694, NCT6694_HWMON_MOD, 283 NCT6694_HWMON_CMD2_OFFSET, 284 NCT6694_HWMON_CMD2_LEN, 285 data->xmit_buf); 286 if (ret) 287 return ret; 288 289 temp_max = (signed char)data->xmit_buf[NCT6694_TIN_HL(channel)]; 290 temp_hyst = FIELD_GET(NCT6694_TIN_HYST_MASK, 291 data->xmit_buf[NCT6694_TIN_HYST(channel)]); 292 if (temp_max < 0) 293 *val = temp_from_reg(temp_max + temp_hyst); 294 else 295 *val = temp_from_reg(temp_max - temp_hyst); 296 297 return 0; 298 case hwmon_temp_max_alarm: 299 ret = nct6694_read_msg(data->nct6694, NCT6694_RPT_MOD, 300 NCT6694_TIN_STS(channel / 8), 1, 301 data->xmit_buf); 302 if (ret) 303 return ret; 304 305 *val = !!(data->xmit_buf[0] & BIT(channel % 8)); 306 307 return 0; 308 default: 309 return -EOPNOTSUPP; 310 } 311 } 312 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki