From: Jakub Kicinski <kuba@kernel.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Saeed Mahameed <saeed@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Yafang Shao <laoar.shao@gmail.com>,
ttoukan.linux@gmail.com, tariqt@nvidia.com, leon@kernel.org,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors
Date: Sat, 23 Nov 2024 18:50:24 -0800 [thread overview]
Message-ID: <20241123185024.21315d99@kernel.org> (raw)
In-Reply-To: <1060ac7d-ad76-4383-906f-9f20a7b8174a@nvidia.com>
On Wed, 20 Nov 2024 08:04:35 +0200 Gal Pressman wrote:
> > The comment just says not to add what's already counted in missed,
> > because profcs adds the two and we'd end up double counting.
>
> So this is a procfs thing only?
> Does that mean that netlink's rx_dropped might be different than procfs'
> rx_dropped?
Yes, procfs and rtnl show "different" stats.
For more context on why I put the comment there -- some stats
the drivers are supposed to fold (error stats from memory).
Legacy stats are tricky, it'd be a major review time investment
to try to improve them..
next prev parent reply other threads:[~2024-11-24 2:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 2:17 [PATCH v2 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors Yafang Shao
2024-11-15 2:27 ` Jakub Kicinski
2024-11-15 3:56 ` Yafang Shao
2024-11-15 4:32 ` Jakub Kicinski
2024-11-15 5:50 ` Yafang Shao
2024-11-15 8:01 ` Saeed Mahameed
2024-11-15 19:24 ` Jakub Kicinski
2024-11-15 19:54 ` Saeed Mahameed
2024-11-15 21:25 ` Jakub Kicinski
2024-11-15 22:09 ` Saeed Mahameed
2024-11-15 22:42 ` Jakub Kicinski
2024-11-20 6:04 ` Gal Pressman
2024-11-24 2:50 ` Jakub Kicinski [this message]
2024-11-17 6:33 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241123185024.21315d99@kernel.org \
--to=kuba@kernel.org \
--cc=gal@nvidia.com \
--cc=laoar.shao@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).