From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99358232D99; Sun, 24 Nov 2024 13:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456221; cv=none; b=OO469TyDs9UVJyTgh2q504NTKh7H/al2cDmb71hxel2TZI3yoBxtMh/HCFR+KrOZmfBumyIUZRWrIrOSPI1aXcODVLS5FBd55wKXMsqI59DZGKyrN9enwUdXPGfe8DecqSNgbFpcOa4gFxzXNVHADuSvjfS79xLaO9HnwYEgGZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456221; c=relaxed/simple; bh=KkpYf8ahpdTMCvArXZvB2+iUqTaGaSYE0sH5JBz9LUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lo0wpkfFFgB//C7RMi9W9vqLmystUFrBWPgc2KAQvJH881edmiL4+fzd82nv3GBbKvtTgH/sR2+Fb/JqYKIg02OAWWyD3aZQgRe/kgmsmlkMfKPFkrfYwQfngCpE2IauYNfLpuUR+W1SP7+XbBAn4S+T+PEU3mOuDszWJZukR98= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pN6sWHiH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pN6sWHiH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37919C4CECC; Sun, 24 Nov 2024 13:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732456221; bh=KkpYf8ahpdTMCvArXZvB2+iUqTaGaSYE0sH5JBz9LUI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pN6sWHiHrhWbwzfKZ+OtaqlYRrlskjioJSxFlb3AUSNoBjx9IxvtvcnXPnKImde3g GzaVIaREBBdYOgfAY6xO1ySXcbr/8SQ46C6realowKSBBTIzDEqhhhGnocQDYZkTwM Pj+EeAQGvac03BoG2/Meg8/jlIYxQk0v0GkrmkVNce67eSd+O5MtETa1ReqmSmTyIb cs3Obe2SLWsO8e4CdcF+WuhYx1zptb/tpbZYJult6wfsnXvQwPVmMswyLTFjPjBLhX KuCrb41vd6H/8RemzxXCfDSvcsbp9D9B/l3/EED4Av1fOG6JYlyhyDK/0t6SbOkg+x hp8HS1f4HdTJg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ignat Korchagin , Eric Dumazet , Kuniyuki Iwashima , Willem de Bruijn , Jakub Kicinski , Sasha Levin , willemdebruijn.kernel@gmail.com, davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 6.1 15/48] af_packet: avoid erroring out after sock_init_data() in packet_create() Date: Sun, 24 Nov 2024 08:48:38 -0500 Message-ID: <20241124134950.3348099-15-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124134950.3348099-1-sashal@kernel.org> References: <20241124134950.3348099-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.1.119 Content-Transfer-Encoding: 8bit From: Ignat Korchagin [ Upstream commit 46f2a11cb82b657fd15bab1c47821b635e03838b ] After sock_init_data() the allocated sk object is attached to the provided sock object. On error, packet_create() frees the sk object leaving the dangling pointer in the sock object on return. Some other code may try to use this pointer and cause use-after-free. Suggested-by: Eric Dumazet Signed-off-by: Ignat Korchagin Reviewed-by: Kuniyuki Iwashima Reviewed-by: Willem de Bruijn Reviewed-by: Eric Dumazet Link: https://patch.msgid.link/20241014153808.51894-2-ignat@cloudflare.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/packet/af_packet.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index c9c813f731c6e..9da9e41899c65 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -3418,18 +3418,18 @@ static int packet_create(struct net *net, struct socket *sock, int protocol, if (sock->type == SOCK_PACKET) sock->ops = &packet_ops_spkt; + po = pkt_sk(sk); + err = packet_alloc_pending(po); + if (err) + goto out_sk_free; + sock_init_data(sock, sk); - po = pkt_sk(sk); init_completion(&po->skb_completion); sk->sk_family = PF_PACKET; po->num = proto; po->xmit = dev_queue_xmit; - err = packet_alloc_pending(po); - if (err) - goto out2; - packet_cached_dev_reset(po); sk->sk_destruct = packet_sock_destruct; @@ -3462,7 +3462,7 @@ static int packet_create(struct net *net, struct socket *sock, int protocol, sock_prot_inuse_add(net, &packet_proto, 1); return 0; -out2: +out_sk_free: sk_free(sk); out: return err; -- 2.43.0