From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2948224D918; Sun, 24 Nov 2024 13:57:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456650; cv=none; b=YdcTdiLw9H7lpsCmy0zRROwVkUABXVoe+0WtlnOrRU4KLcMlwRT0o0eKOTSfBCPh0jtQt5GCubBsYEVUvkKWXXZoEKJBRrAgC7n13lvF8xg8wY6w1+68o9Z8l30t2WijiL7Pr24x4ZL0MMbc6D7q137b7ZP47EFijpY3xdO3C4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456650; c=relaxed/simple; bh=E380sr4Hy676F8Xv/FDoioZLqP7w0J7HImFkZP80t4I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Tat5iaxKJjbzu6AdCygy0vZ36ROms9+8KeSs+bU1R2Q2yMmTqrpERZ/hq2+Xs4hfG46PJFTHP2zmaZD8BwvB4lGKbjQUnmZvX3aQCbIDTLzQdM8OTnVmbP/c0l44MXbsJ7QUjan0pZD01kHm+8txgndqd2wTZCWjqywQVIAAN5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UuizFY7P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UuizFY7P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C7E8C4CED3; Sun, 24 Nov 2024 13:57:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732456649; bh=E380sr4Hy676F8Xv/FDoioZLqP7w0J7HImFkZP80t4I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UuizFY7P9MMOFM2+HhgB4kT2mBWLGrymg3a6I9fO2cVYiie/f/YTMH9bNPeOVUF87 ILhLTuqB3gIMJMg5uxJ1UR0itgeZx9qgp4teLpwaPtDiCj2wabbxiuhmjN0hoXokC4 XFDumcXsZFcxH54TXZ7Jowate6XvcjAUTgXaaW3syEmQ+X+RnBl4vSPo34EBUX9N6y HJobwIqyuLmeLlegZgLNUATLDo+sROl+OSYs+s9mYcvipaj0+0V4WSLprIrSFc9XAE jbRRdx7gu08OwQ3ZBvk1FXbpkc2ldGtT7vMKEqDutHfRuvUESmyRDtDq7KmfxDJGWt G9umSgtQtExzg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ignat Korchagin , Kuniyuki Iwashima , Eric Dumazet , Jakub Kicinski , Sasha Levin , davem@davemloft.net, dsahern@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 10/21] net: inet6: do not leave a dangling sk pointer in inet6_create() Date: Sun, 24 Nov 2024 08:56:43 -0500 Message-ID: <20241124135709.3351371-10-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124135709.3351371-1-sashal@kernel.org> References: <20241124135709.3351371-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.324 Content-Transfer-Encoding: 8bit From: Ignat Korchagin [ Upstream commit 9df99c395d0f55fb444ef39f4d6f194ca437d884 ] sock_init_data() attaches the allocated sk pointer to the provided sock object. If inet6_create() fails later, the sk object is released, but the sock object retains the dangling sk pointer, which may cause use-after-free later. Clear the sock sk pointer on error. Signed-off-by: Ignat Korchagin Reviewed-by: Kuniyuki Iwashima Reviewed-by: Eric Dumazet Link: https://patch.msgid.link/20241014153808.51894-8-ignat@cloudflare.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv6/af_inet6.c | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index f480436b84339..2de90056bdf22 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c @@ -253,31 +253,29 @@ static int inet6_create(struct net *net, struct socket *sock, int protocol, */ inet->inet_sport = htons(inet->inet_num); err = sk->sk_prot->hash(sk); - if (err) { - sk_common_release(sk); - goto out; - } + if (err) + goto out_sk_release; } if (sk->sk_prot->init) { err = sk->sk_prot->init(sk); - if (err) { - sk_common_release(sk); - goto out; - } + if (err) + goto out_sk_release; } if (!kern) { err = BPF_CGROUP_RUN_PROG_INET_SOCK(sk); - if (err) { - sk_common_release(sk); - goto out; - } + if (err) + goto out_sk_release; } out: return err; out_rcu_unlock: rcu_read_unlock(); goto out; +out_sk_release: + sk_common_release(sk); + sock->sk = NULL; + goto out; } static int __inet6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len, -- 2.43.0