From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6E6A24C705; Sun, 24 Nov 2024 13:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456639; cv=none; b=f7XWqsmrdmqKu17n+pW8fGrayNV2uF/K9qJ7xAY0sC66d/DpTULjkSeIrslKZ9/xH4OArn80WsQo5X5iH52N4VBSBZ5XcwGA0E8PPGTWzGPhio1f6nX9E43freOtxE2gPJcWSpMop/iYnit4B75PMAfta7C49rzPNu+4o/Riu8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732456639; c=relaxed/simple; bh=7kJxGYpq5B6gkcecesOBUZjReUx4nZbMinW6ZwXQQO8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ECbQU3CShtrIEm3QQpVQbwYBGpbdxFYIN2Xwi2gOzBaAuwCwvqXGRID3XnRmVKDbWIozTZiDgt89wPzZoyOVTkf/mQ7sY+Va2PGSohW30ak15PbzsnB1SadLqNVwKdifAIG9rNgiyLNKdNIDPiq5T/2OFIJFfFmdbn88pYXJgPQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=q0EUxG8p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q0EUxG8p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7169C4CECC; Sun, 24 Nov 2024 13:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732456639; bh=7kJxGYpq5B6gkcecesOBUZjReUx4nZbMinW6ZwXQQO8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q0EUxG8piPrclZWVAoqpmjpjhiHP20D+D2R+LHeQZcCKs9Z0sYTGCPyG8li0rAvKu A99XLr/oD69Qtu7HutwdZ7OSxQ2BjiIpcxgYOYSXxtA3uDxajh7wtXSwoJdNoRKg03 gC+8in/knjT8NXBwyI+mu6EHTa2z5P/JxbeMJ5ab8yYHRcb8EqF1M+feYCy5VHQo69 BjmciJ8sPrcfySTWh/XD+yXYAM4iBiez0KzYhhVCf6um/5Y6AxA4gwubxMEPsDstSZ kMas5arQqK0QVHuUrtqZLb6zM8uVYzWD4YDMMjVf37SgTrn9cGjm2kDiVFMXeWgGrA PWS34ESYL5fLA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Simon Horman , Geert Uytterhoeven , Daniel Machon , Jakub Kicinski , Sasha Levin , pantelis.antoniou@gmail.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 04/21] net: ethernet: fs_enet: Use %pa to format resource_size_t Date: Sun, 24 Nov 2024 08:56:37 -0500 Message-ID: <20241124135709.3351371-4-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124135709.3351371-1-sashal@kernel.org> References: <20241124135709.3351371-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 4.19.324 Content-Transfer-Encoding: 8bit From: Simon Horman [ Upstream commit 45fe45fada261e1e83fce2a07fa22835aec1cf0a ] The correct format string for resource_size_t is %pa which acts on the address of the variable to be formatted [1]. [1] https://elixir.bootlin.com/linux/v6.11.3/source/Documentation/core-api/printk-formats.rst#L229 Introduced by commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string") Flagged by gcc-14 as: drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c: In function 'fs_mii_bitbang_init': drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c:126:46: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t' {aka 'long long unsigned int'} [-Wformat=] 126 | snprintf(bus->id, MII_BUS_ID_SIZE, "%x", res.start); | ~^ ~~~~~~~~~ | | | | | resource_size_t {aka long long unsigned int} | unsigned int | %llx No functional change intended. Compile tested only. Reported-by: Geert Uytterhoeven Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cce99@linux-m68k.org/ Signed-off-by: Simon Horman Reviewed-by: Daniel Machon Link: https://patch.msgid.link/20241014-net-pa-fmt-v1-2-dcc9afb8858b@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c index 21de56345503f..f743112730194 100644 --- a/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c +++ b/drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c @@ -126,7 +126,7 @@ static int fs_mii_bitbang_init(struct mii_bus *bus, struct device_node *np) * we get is an int, and the odds of multiple bitbang mdio buses * is low enough that it's not worth going too crazy. */ - snprintf(bus->id, MII_BUS_ID_SIZE, "%x", res.start); + snprintf(bus->id, MII_BUS_ID_SIZE, "%pa", &res.start); data = of_get_property(np, "fsl,mdio-pin", &len); if (!data || len != 4) -- 2.43.0