From: Milena Olech <milena.olech@intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com,
Milena Olech <milena.olech@intel.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>
Subject: [PATCH v2 iwl-next 10/10] idpf: change the method for mailbox workqueue allocation
Date: Tue, 26 Nov 2024 04:58:57 +0100 [thread overview]
Message-ID: <20241126035849.6441-11-milena.olech@intel.com> (raw)
In-Reply-To: <20241126035849.6441-1-milena.olech@intel.com>
Since workqueues are created per CPU, the works scheduled to this
workqueues are run on the CPU they were assigned. It may result in
overloaded CPU that is not able to handle virtchnl messages in
relatively short time. Allocating workqueue with WQ_UNBOUND and
WQ_HIGHPRI flags allows scheduler to queue virtchl messages on less loaded
CPUs, what eliminates delays.
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Signed-off-by: Milena Olech <milena.olech@intel.com>
---
drivers/net/ethernet/intel/idpf/idpf_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/idpf/idpf_main.c b/drivers/net/ethernet/intel/idpf/idpf_main.c
index 9fe0940f81b0..afc39e894cd2 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_main.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_main.c
@@ -220,8 +220,8 @@ static int idpf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
goto err_serv_wq_alloc;
}
- adapter->mbx_wq = alloc_workqueue("%s-%s-mbx", 0, 0,
- dev_driver_string(dev),
+ adapter->mbx_wq = alloc_workqueue("%s-%s-mbx", WQ_UNBOUND | WQ_HIGHPRI,
+ 0, dev_driver_string(dev),
dev_name(dev));
if (!adapter->mbx_wq) {
dev_err(dev, "Failed to allocate mailbox workqueue\n");
--
2.31.1
prev parent reply other threads:[~2024-11-26 11:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 3:58 [PATCH v2 iwl-next 00/10] add initial PTP support Milena Olech
2024-11-26 3:58 ` [PATCH v2 iwl-next 01/10] idpf: " Milena Olech
2024-11-26 3:58 ` [PATCH v2 iwl-next 02/10] virtchnl: add PTP virtchnl definitions Milena Olech
2024-11-26 3:58 ` [PATCH v2 iwl-next 03/10] idpf: move virtchnl structures to the header file Milena Olech
2024-11-26 3:58 ` [PATCH v2 iwl-next 04/10] idpf: negotiate PTP capabilities and get PTP clock Milena Olech
2024-11-27 15:34 ` Willem de Bruijn
2024-11-26 3:58 ` [PATCH v2 iwl-next 05/10] idpf: add mailbox access to read PTP clock time Milena Olech
2024-11-26 3:58 ` [PATCH v2 iwl-next 06/10] idpf: add PTP clock configuration Milena Olech
2024-11-26 3:58 ` [PATCH v2 iwl-next 07/10] idpf: add Tx timestamp capabilities negotiation Milena Olech
2024-11-29 15:37 ` Willem de Bruijn
2024-12-18 15:02 ` Olech, Milena
2024-12-03 14:56 ` Simon Horman
2024-12-18 15:08 ` Olech, Milena
2024-11-26 3:58 ` [PATCH v2 iwl-next 08/10] idpf: add Tx timestamp flows Milena Olech
2024-11-26 12:36 ` Vadim Fedorenko
2024-11-29 15:46 ` Willem de Bruijn
2024-12-18 15:33 ` Olech, Milena
2024-11-26 3:58 ` [PATCH v2 iwl-next 09/10] idpf: add support for Rx timestamping Milena Olech
2024-11-29 15:48 ` Willem de Bruijn
2024-12-18 15:39 ` Olech, Milena
2024-11-26 3:58 ` Milena Olech [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241126035849.6441-11-milena.olech@intel.com \
--to=milena.olech@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).