From: kernel test robot <lkp@intel.com>
To: Andy Strohman <andrew@andrewstrohman.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com,
Shahed Shaikh <shshaikh@marvell.com>,
Manish Chopra <manishc@marvell.com>,
GR-Linux-NIC-Dev@marvell.com, Simon Horman <horms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org,
Andy Strohman <andrew@andrewstrohman.com>,
intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, bridge@lists.linux.dev
Subject: Re: [PATCH net-next] bridge: Make the FDB consider inner tag for Q-in-Q
Date: Sat, 30 Nov 2024 13:47:38 +0800 [thread overview]
Message-ID: <202411301325.5uGYbi6q-lkp@intel.com> (raw)
In-Reply-To: <20241130000802.2822146-1-andrew@andrewstrohman.com>
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Strohman/bridge-Make-the-FDB-consider-inner-tag-for-Q-in-Q/20241130-080335
base: net-next/main
patch link: https://lore.kernel.org/r/20241130000802.2822146-1-andrew%40andrewstrohman.com
patch subject: [PATCH net-next] bridge: Make the FDB consider inner tag for Q-in-Q
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241130/202411301325.5uGYbi6q-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241130/202411301325.5uGYbi6q-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411301325.5uGYbi6q-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/intel/i40e/i40e_main.c:13106: warning: Function parameter or struct member 'inner_vid' not described in 'i40e_ndo_fdb_add'
--
>> drivers/net/ethernet/intel/ice/ice_main.c:6167: warning: Function parameter or struct member 'inner_vid' not described in 'ice_fdb_add'
>> drivers/net/ethernet/intel/ice/ice_main.c:6208: warning: Function parameter or struct member 'inner_vid' not described in 'ice_fdb_del'
vim +13106 drivers/net/ethernet/intel/i40e/i40e_main.c
1f224ad2f76028 Neerav Parikh 2014-02-12 13089
2f90ade661b3bd Jesse Brandeburg 2014-11-20 13090 /**
2f90ade661b3bd Jesse Brandeburg 2014-11-20 13091 * i40e_ndo_fdb_add - add an entry to the hardware database
2f90ade661b3bd Jesse Brandeburg 2014-11-20 13092 * @ndm: the input from the stack
2f90ade661b3bd Jesse Brandeburg 2014-11-20 13093 * @tb: pointer to array of nladdr (unused)
2f90ade661b3bd Jesse Brandeburg 2014-11-20 13094 * @dev: the net device pointer
2f90ade661b3bd Jesse Brandeburg 2014-11-20 13095 * @addr: the MAC address entry being added
f5254429e1756a Jacob Keller 2018-04-20 13096 * @vid: VLAN ID
2f90ade661b3bd Jesse Brandeburg 2014-11-20 13097 * @flags: instructions from stack about fdb operation
4b42fbc6bd8f73 Petr Machata 2024-11-14 13098 * @notified: whether notification was emitted
b50f7bca5e83d9 Jesse Brandeburg 2020-09-25 13099 * @extack: netlink extended ack, unused currently
2f90ade661b3bd Jesse Brandeburg 2014-11-20 13100 */
4ba0dea5b17369 Greg Rose 2014-03-06 13101 static int i40e_ndo_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
4ba0dea5b17369 Greg Rose 2014-03-06 13102 struct net_device *dev,
eae5d6a6f80427 Andy Strohman 2024-11-30 13103 const unsigned char *addr, u16 vid, u16 inner_vid,
4b42fbc6bd8f73 Petr Machata 2024-11-14 13104 u16 flags, bool *notified,
87b0984ebfabaf Petr Machata 2019-01-16 13105 struct netlink_ext_ack *extack)
4ba0dea5b17369 Greg Rose 2014-03-06 @13106 {
4ba0dea5b17369 Greg Rose 2014-03-06 13107 struct i40e_netdev_priv *np = netdev_priv(dev);
4ba0dea5b17369 Greg Rose 2014-03-06 13108 struct i40e_pf *pf = np->vsi->back;
4ba0dea5b17369 Greg Rose 2014-03-06 13109 int err = 0;
4ba0dea5b17369 Greg Rose 2014-03-06 13110
70756d0a4727fe Ivan Vecera 2023-11-13 13111 if (!test_bit(I40E_FLAG_SRIOV_ENA, pf->flags))
4ba0dea5b17369 Greg Rose 2014-03-06 13112 return -EOPNOTSUPP;
4ba0dea5b17369 Greg Rose 2014-03-06 13113
eae5d6a6f80427 Andy Strohman 2024-11-30 13114 if (vid || inner_vid) {
65891feac27e26 Or Gerlitz 2014-12-14 13115 pr_info("%s: vlans aren't supported yet for dev_uc|mc_add()\n", dev->name);
65891feac27e26 Or Gerlitz 2014-12-14 13116 return -EINVAL;
65891feac27e26 Or Gerlitz 2014-12-14 13117 }
65891feac27e26 Or Gerlitz 2014-12-14 13118
4ba0dea5b17369 Greg Rose 2014-03-06 13119 /* Hardware does not support aging addresses so if a
4ba0dea5b17369 Greg Rose 2014-03-06 13120 * ndm_state is given only allow permanent addresses
4ba0dea5b17369 Greg Rose 2014-03-06 13121 */
4ba0dea5b17369 Greg Rose 2014-03-06 13122 if (ndm->ndm_state && !(ndm->ndm_state & NUD_PERMANENT)) {
4ba0dea5b17369 Greg Rose 2014-03-06 13123 netdev_info(dev, "FDB only supports static addresses\n");
4ba0dea5b17369 Greg Rose 2014-03-06 13124 return -EINVAL;
4ba0dea5b17369 Greg Rose 2014-03-06 13125 }
4ba0dea5b17369 Greg Rose 2014-03-06 13126
4ba0dea5b17369 Greg Rose 2014-03-06 13127 if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr))
4ba0dea5b17369 Greg Rose 2014-03-06 13128 err = dev_uc_add_excl(dev, addr);
4ba0dea5b17369 Greg Rose 2014-03-06 13129 else if (is_multicast_ether_addr(addr))
4ba0dea5b17369 Greg Rose 2014-03-06 13130 err = dev_mc_add_excl(dev, addr);
4ba0dea5b17369 Greg Rose 2014-03-06 13131 else
4ba0dea5b17369 Greg Rose 2014-03-06 13132 err = -EINVAL;
4ba0dea5b17369 Greg Rose 2014-03-06 13133
4ba0dea5b17369 Greg Rose 2014-03-06 13134 /* Only return duplicate errors if NLM_F_EXCL is set */
4ba0dea5b17369 Greg Rose 2014-03-06 13135 if (err == -EEXIST && !(flags & NLM_F_EXCL))
4ba0dea5b17369 Greg Rose 2014-03-06 13136 err = 0;
4ba0dea5b17369 Greg Rose 2014-03-06 13137
4ba0dea5b17369 Greg Rose 2014-03-06 13138 return err;
4ba0dea5b17369 Greg Rose 2014-03-06 13139 }
4ba0dea5b17369 Greg Rose 2014-03-06 13140
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-11-30 5:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 0:07 [PATCH net-next] bridge: Make the FDB consider inner tag for Q-in-Q Andy Strohman
2024-11-30 5:47 ` kernel test robot [this message]
2024-11-30 16:04 ` Nikolay Aleksandrov
2024-11-30 16:08 ` Vladimir Oltean
2024-11-30 23:03 ` Andrew Strohman
2024-11-30 22:28 ` Andrew Strohman
2024-12-02 10:06 ` Vladimir Oltean
2024-12-04 8:37 ` Andrew Strohman
2024-12-04 8:48 ` Vladimir Oltean
2024-12-04 10:12 ` Andrew Strohman
2024-12-04 10:56 ` Vladimir Oltean
2024-12-05 1:14 ` Andrew Strohman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411301325.5uGYbi6q-lkp@intel.com \
--to=lkp@intel.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@andrewstrohman.com \
--cc=anthony.l.nguyen@intel.com \
--cc=bridge@lists.linux.dev \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=rostedt@goodmis.org \
--cc=shshaikh@marvell.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox