From: Jakub Kicinski <kuba@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH iwl-net 1/2] idpf: preserve IRQ affinity settings across resets
Date: Mon, 2 Dec 2024 06:26:39 -0800 [thread overview]
Message-ID: <20241202062639.30ddac57@kernel.org> (raw)
In-Reply-To: <96df3bc7-85ab-4e21-a26d-3785874454a8@intel.com>
On Mon, 2 Dec 2024 06:03:45 -0700 Ahmed Zaki wrote:
> On 2024-11-11 7:53 p.m., Jakub Kicinski wrote:
> > On Fri, 8 Nov 2024 17:12:05 -0700 Ahmed Zaki wrote:
> >> From: Sudheer Mogilappagari <sudheer.mogilappagari@intel.com>
> >>
> >> Currently the IRQ affinity settings are getting lost when interface
> >> goes through a soft reset (due to MTU configuration, changing number
> >> of queues etc). Use irq_set_affinity_notifier() callbacks to keep
> >> the IRQ affinity info in sync between driver and kernel.
> >
> > Could you try doing this in the core? Store the mask in napi_struct
> > if it has IRQ associated with it?
> >
> > Barely any drivers get this right.
>
> The napi structs are allocated/freed with open/close ndos. I don't think
> we should expect the user to re-set CPU affinity after link down/up.
The napi_config struct is persistent.
next prev parent reply other threads:[~2024-12-02 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-09 0:12 [PATCH iwl-net 0/2] idpf: Preserve IRQ affinity and sync IRQ Ahmed Zaki
2024-11-09 0:12 ` [PATCH iwl-net 1/2] idpf: preserve IRQ affinity settings across resets Ahmed Zaki
2024-11-12 2:53 ` Jakub Kicinski
2024-12-02 13:03 ` Ahmed Zaki
2024-12-02 14:26 ` Jakub Kicinski [this message]
2024-11-09 0:12 ` [PATCH iwl-net 2/2] idpf: finish pending IRQ handling before freeing interrupt Ahmed Zaki
2024-11-12 2:54 ` Jakub Kicinski
2024-12-02 13:11 ` Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202062639.30ddac57@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).