From: Vladimir Oltean <olteanv@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Andy Strohman <andrew@andrewstrohman.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] dsa: Make offloading optional on per port basis
Date: Mon, 2 Dec 2024 11:45:08 +0200 [thread overview]
Message-ID: <20241202094508.4tpbed2b4amyvbsi@skbuf> (raw)
In-Reply-To: <Z019fbECX6R4HHpm@nanopsycho.orion>
On Mon, Dec 02, 2024 at 10:27:25AM +0100, Jiri Pirko wrote:
> Why is this DSA specific? Plus, you say you want to disable offloading
> in general (DSA_FLAG_OFFLOADING_DISABLED), but you check the flag only
> when joining bridge. I mean, shouldn't this be rather something exposed
> by some common UAPI?
I agree with this. The proposed functionality isn't DSA specific, and
thus, the UAPI to configure it shouldn't be made so.
> Btw, isn't NETIF_F_HW_L2FW_DOFFLOAD what you are looking for?
Is it? macvlan uses NETIF_F_HW_L2FW_DOFFLOAD to detect presence of
netdev_ops->ndo_dfwd_add_station(). Having to even consider macvlan
offload and its implications just because somebody decided to monopolize
the "l2-fwd-offload" name seems at least bizarre in my opinion.
next prev parent reply other threads:[~2024-12-02 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-01 7:42 [PATCH net-next] dsa: Make offloading optional on per port basis Andy Strohman
2024-12-02 9:27 ` Jiri Pirko
2024-12-02 9:45 ` Vladimir Oltean [this message]
2024-12-11 6:31 ` Andrew Strohman
2024-12-11 6:12 ` Andrew Strohman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202094508.4tpbed2b4amyvbsi@skbuf \
--to=olteanv@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@andrewstrohman.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox