From: Jakub Kicinski <kuba@kernel.org>
To: "Krzysztof Hałasa" <khalasa@piap.pl>
Cc: netdev <netdev@vger.kernel.org>, Oliver Neukum <oneukum@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Jose Ignacio Tornos Martinez <jtornosm@redhat.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH] USBNET: Fix ASIX USB Ethernet carrier problems.
Date: Mon, 2 Dec 2024 19:24:04 -0800 [thread overview]
Message-ID: <20241202192404.4713b1f9@kernel.org> (raw)
In-Reply-To: <m3v7w9hxp1.fsf@t19.piap.pl>
On Wed, 27 Nov 2024 09:45:30 +0100 Krzysztof Hałasa wrote:
> To: netdev <netdev@vger.kernel.org>
> Cc: Oliver Neukum <oneukum@suse.com>, Andrew Lunn <andrew+netdev@lunn.ch>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jose Ignacio Tornos Martinez <jtornosm@redhat.com>, Ming Lei <ming.lei@redhat.com>
Please add to the CC list some folks who worked on phylib and phylink
support for this driver. They will be best reviewers.
> Subject: [PATCH] USBNET: Fix ASIX USB Ethernet carrier problems.
No need to spell out USBNET in all caps. I'd rename the subject to:
usbnet: asix: leave the carrier control to phylink
If we say it's a 'fix' we should really point at the commit which broke
things with a Fixes: tag. If your device never worked it's better to act
as if it was "support for a new device". Otherwise various semi-
-automated backport bots will suck this change in, and given the general
dependability of ASIX devices... seems risky..
> Date: Wed, 27 Nov 2024 09:45:30 +0100
> Sender: khalasa@piap.pl
>
> Hi,
No need to say "Hi" in the commit message :)
--
pw-bot: cr
prev parent reply other threads:[~2024-12-03 3:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 8:45 [PATCH] USBNET: Fix ASIX USB Ethernet carrier problems Krzysztof Hałasa
2024-12-03 3:24 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202192404.4713b1f9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jtornosm@redhat.com \
--cc=khalasa@piap.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).