From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, pawel.chmielewski@intel.com,
sridhar.samudrala@intel.com, jacob.e.keller@intel.com,
pio.raczynski@gmail.com, konrad.knitter@intel.com,
marcin.szycik@intel.com, wojciech.drewek@intel.com,
nex.sw.ncis.nat.hpm.dev@intel.com, przemyslaw.kitszel@intel.com,
jiri@resnulli.us, horms@kernel.org, David.Laight@ACULAB.COM,
pmenzel@molgen.mpg.de, mschmidt@redhat.com,
himasekharx.reddy.pucha@intel.com, rafal.romanowski@intel.com
Subject: [iwl-next v9 9/9] ice: init flow director before RDMA
Date: Tue, 3 Dec 2024 07:58:17 +0100 [thread overview]
Message-ID: <20241203065817.13475-10-michal.swiatkowski@linux.intel.com> (raw)
In-Reply-To: <20241203065817.13475-1-michal.swiatkowski@linux.intel.com>
Flow director needs only one MSI-X. Load it before RDMA to save MSI-X
for it.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
---
drivers/net/ethernet/intel/ice/ice_main.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 7b9be612cf33..576bff42f440 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -5180,11 +5180,12 @@ int ice_load(struct ice_pf *pf)
ice_napi_add(vsi);
+ ice_init_features(pf);
+
err = ice_init_rdma(pf);
if (err)
goto err_init_rdma;
- ice_init_features(pf);
ice_service_task_restart(pf);
clear_bit(ICE_DOWN, pf->state);
@@ -5192,6 +5193,7 @@ int ice_load(struct ice_pf *pf)
return 0;
err_init_rdma:
+ ice_deinit_features(pf);
ice_tc_indir_block_unregister(vsi);
err_tc_indir_block_register:
ice_unregister_netdev(vsi);
@@ -5215,8 +5217,8 @@ void ice_unload(struct ice_pf *pf)
devl_assert_locked(priv_to_devlink(pf));
- ice_deinit_features(pf);
ice_deinit_rdma(pf);
+ ice_deinit_features(pf);
ice_tc_indir_block_unregister(vsi);
ice_unregister_netdev(vsi);
ice_devlink_destroy_pf_port(pf);
--
2.42.0
prev parent reply other threads:[~2024-12-03 6:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 6:58 [iwl-next v9 0/9] ice: managing MSI-X in driver Michal Swiatkowski
2024-12-03 6:58 ` [iwl-next v9 1/9] ice: count combined queues using Rx/Tx count Michal Swiatkowski
2024-12-03 6:58 ` [iwl-next v9 2/9] ice: devlink PF MSI-X max and min parameter Michal Swiatkowski
2024-12-03 6:58 ` [iwl-next v9 3/9] ice: remove splitting MSI-X between features Michal Swiatkowski
2024-12-03 6:58 ` [iwl-next v9 4/9] ice: get rid of num_lan_msix field Michal Swiatkowski
2024-12-03 6:58 ` [iwl-next v9 5/9] ice, irdma: move interrupts code to irdma Michal Swiatkowski
2025-02-13 19:20 ` [Intel-wired-lan] " Marcin Szycik
2025-02-14 5:41 ` Michal Swiatkowski
2024-12-03 6:58 ` [iwl-next v9 6/9] ice: treat dyn_allowed only as suggestion Michal Swiatkowski
2024-12-03 6:58 ` [iwl-next v9 7/9] ice: enable_rdma devlink param Michal Swiatkowski
2024-12-03 6:58 ` [iwl-next v9 8/9] ice: simplify VF MSI-X managing Michal Swiatkowski
2024-12-03 6:58 ` Michal Swiatkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203065817.13475-10-michal.swiatkowski@linux.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=David.Laight@ACULAB.COM \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=konrad.knitter@intel.com \
--cc=marcin.szycik@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.nat.hpm.dev@intel.com \
--cc=pawel.chmielewski@intel.com \
--cc=pio.raczynski@gmail.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=rafal.romanowski@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).