From: Donald Hunter <donald.hunter@gmail.com>
To: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: donald.hunter@redhat.com, Donald Hunter <donald.hunter@gmail.com>
Subject: [PATCH net-next v1 4/7] tools/net/ynl: accept IP string inputs
Date: Tue, 3 Dec 2024 13:06:52 +0000 [thread overview]
Message-ID: <20241203130655.45293-5-donald.hunter@gmail.com> (raw)
In-Reply-To: <20241203130655.45293-1-donald.hunter@gmail.com>
The ynl tool uses display-hint to know when to format IP addresses in
printed output, but not to parse IP addresses from --json input. Add
support for parsing ipv4 and ipv6 strings.
Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
---
tools/net/ynl/lib/ynl.py | 24 ++++++++++++++++++++----
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py
index f07a8404f71a..c861c1a7d933 100644
--- a/tools/net/ynl/lib/ynl.py
+++ b/tools/net/ynl/lib/ynl.py
@@ -536,9 +536,11 @@ class YnlFamily(SpecFamily):
try:
return int(value)
except (ValueError, TypeError) as e:
- if 'enum' not in attr_spec:
- raise e
- return self._encode_enum(attr_spec, value)
+ if 'enum' in attr_spec:
+ return self._encode_enum(attr_spec, value)
+ if attr_spec.display_hint:
+ return self._from_string(value, attr_spec.display_hint, attr_spec['type'])
+ raise e
def _add_attr(self, space, name, value, search_attrs):
try:
@@ -571,7 +573,10 @@ class YnlFamily(SpecFamily):
if isinstance(value, bytes):
attr_payload = value
elif isinstance(value, str):
- attr_payload = bytes.fromhex(value)
+ if attr.display_hint:
+ attr_payload = self._from_string(value, attr.display_hint, attr['type'])
+ else:
+ attr_payload = bytes.fromhex(value)
elif isinstance(value, dict) and attr.struct_name:
attr_payload = self._encode_struct(attr.struct_name, value)
else:
@@ -899,6 +904,17 @@ class YnlFamily(SpecFamily):
formatted = raw
return formatted
+ def _from_string(self, string, display_hint, type):
+ if display_hint in ['ipv4', 'ipv6']:
+ ip = ipaddress.ip_address(string)
+ if type == 'binary':
+ raw = ip.packed
+ else:
+ raw = int(ip)
+ else:
+ raw = string
+ return raw
+
def handle_ntf(self, decoded):
msg = dict()
if self.include_raw:
--
2.47.1
next prev parent reply other threads:[~2024-12-03 13:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 13:06 [PATCH net-next v1 0/7] netlink: specs: add a spec for nl80211 wiphy Donald Hunter
2024-12-03 13:06 ` [PATCH net-next v1 1/7] tools/net/ynl: remove extraneous plural from variable names Donald Hunter
2024-12-04 1:56 ` Jakub Kicinski
2024-12-03 13:06 ` [PATCH net-next v1 2/7] tools/net/ynl: support decoding indexed arrays as enums Donald Hunter
2024-12-04 2:00 ` Jakub Kicinski
2024-12-04 13:20 ` Donald Hunter
2024-12-03 13:06 ` [PATCH net-next v1 3/7] tools/net/ynl: support decoding C " Donald Hunter
2024-12-04 2:03 ` Jakub Kicinski
2024-12-04 13:24 ` Donald Hunter
2024-12-03 13:06 ` Donald Hunter [this message]
2024-12-04 2:07 ` [PATCH net-next v1 4/7] tools/net/ynl: accept IP string inputs Jakub Kicinski
2024-12-04 13:37 ` Donald Hunter
2024-12-10 12:00 ` Donald Hunter
2024-12-03 13:06 ` [PATCH net-next v1 5/7] netlink: specs: support nested structs in genetlink legacy Donald Hunter
2024-12-04 2:07 ` Jakub Kicinski
2024-12-03 13:06 ` [PATCH net-next v1 6/7] netlink: specs: add s8, s16 to genetlink schemas Donald Hunter
2024-12-04 2:08 ` Jakub Kicinski
2024-12-03 13:06 ` [PATCH net-next v1 7/7] netlink: specs: wireless: add a spec for nl80211 Donald Hunter
2024-12-03 13:12 ` Johannes Berg
2024-12-04 13:12 ` Donald Hunter
2024-12-04 13:28 ` Johannes Berg
2024-12-04 14:08 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203130655.45293-5-donald.hunter@gmail.com \
--to=donald.hunter@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).