From: Jakub Kicinski <kuba@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
richardcochran@gmail.com, yangbo.lu@nxp.com, dwmw2@infradead.org,
Linus Torvalds <torvalds@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Linux-Next <linux-next@vger.kernel.org>
Subject: Re: [PATCH] ptp: Switch back to struct platform_driver::remove()
Date: Tue, 3 Dec 2024 17:19:10 -0800 [thread overview]
Message-ID: <20241203171910.27c0a170@kernel.org> (raw)
In-Reply-To: <5qiehbnmzufzqjgn2l4jcghebdx7llr52lgl7hi2jizpg7gfnd@c73bpxxxdeiv>
On Tue, 3 Dec 2024 12:49:54 +0100 Uwe Kleine-König wrote:
> > Resolution: just take the version from upstream.
>
> But IMHO my variant is better than Linus's. After Linus' change the =
> for .probe and .remove are aligned in the conflicting files. However the
> other members initialized there are only using a single space before the
> =. My change used the single space variant consistently for the whole
> initializer.
>
> So I suggest to either drop my change, or in the conflict resolution
> take my variant and not Linus's.
I'll revert, it's less work.
prev parent reply other threads:[~2024-12-04 1:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 14:53 [PATCH] ptp: Switch back to struct platform_driver::remove() Uwe Kleine-König
2024-11-30 14:59 ` Richard Cochran
2024-11-30 17:34 ` Uwe Kleine-König
2024-11-30 19:01 ` Jakub Kicinski
2024-11-30 21:03 ` Richard Cochran
2024-12-03 0:30 ` patchwork-bot+netdevbpf
2024-12-03 9:48 ` Geert Uytterhoeven
2024-12-03 11:49 ` Uwe Kleine-König
2024-12-04 1:19 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203171910.27c0a170@kernel.org \
--to=kuba@kernel.org \
--cc=dwmw2@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).