From: Jakub Kicinski <kuba@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, donald.hunter@redhat.com
Subject: Re: [PATCH net-next v1 1/7] tools/net/ynl: remove extraneous plural from variable names
Date: Tue, 3 Dec 2024 17:56:52 -0800 [thread overview]
Message-ID: <20241203175652.5cf2434b@kernel.org> (raw)
In-Reply-To: <20241203130655.45293-2-donald.hunter@gmail.com>
On Tue, 3 Dec 2024 13:06:49 +0000 Donald Hunter wrote:
> _decode_array_attr() uses variable subattrs in every branch when only
> one branch decodes more than a single attribute.
>
> Change the variable name to subattr in the branches that only decode a
> single attribute so that the intent is more obvious.
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2024-12-04 1:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 13:06 [PATCH net-next v1 0/7] netlink: specs: add a spec for nl80211 wiphy Donald Hunter
2024-12-03 13:06 ` [PATCH net-next v1 1/7] tools/net/ynl: remove extraneous plural from variable names Donald Hunter
2024-12-04 1:56 ` Jakub Kicinski [this message]
2024-12-03 13:06 ` [PATCH net-next v1 2/7] tools/net/ynl: support decoding indexed arrays as enums Donald Hunter
2024-12-04 2:00 ` Jakub Kicinski
2024-12-04 13:20 ` Donald Hunter
2024-12-03 13:06 ` [PATCH net-next v1 3/7] tools/net/ynl: support decoding C " Donald Hunter
2024-12-04 2:03 ` Jakub Kicinski
2024-12-04 13:24 ` Donald Hunter
2024-12-03 13:06 ` [PATCH net-next v1 4/7] tools/net/ynl: accept IP string inputs Donald Hunter
2024-12-04 2:07 ` Jakub Kicinski
2024-12-04 13:37 ` Donald Hunter
2024-12-10 12:00 ` Donald Hunter
2024-12-03 13:06 ` [PATCH net-next v1 5/7] netlink: specs: support nested structs in genetlink legacy Donald Hunter
2024-12-04 2:07 ` Jakub Kicinski
2024-12-03 13:06 ` [PATCH net-next v1 6/7] netlink: specs: add s8, s16 to genetlink schemas Donald Hunter
2024-12-04 2:08 ` Jakub Kicinski
2024-12-03 13:06 ` [PATCH net-next v1 7/7] netlink: specs: wireless: add a spec for nl80211 Donald Hunter
2024-12-03 13:12 ` Johannes Berg
2024-12-04 13:12 ` Donald Hunter
2024-12-04 13:28 ` Johannes Berg
2024-12-04 14:08 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203175652.5cf2434b@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).