From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE42317BA1; Wed, 4 Dec 2024 03:51:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733284290; cv=none; b=lI9MckT0DMZb5Ag6cpG95VFA+bEJM3r2VWWZCxDDr4WxqUCINGEHRgUEeeJsk1eaLyIqNYDL5zXJTr2Sq7zJ29sHSClMBrYKQTqChdmI3CG8EizrzUianiTU0wrgb+3HbdGwCgObnLMPT9w8o2cOa10wWD0/MXpdh4mVkEmjawQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733284290; c=relaxed/simple; bh=bkl1fC1asdNySiWZpwGEDHKtEKnC7uWcPKi06Qhd4pw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pabh9wBAKAxbjzXdvrfrV8kt+xeEoA8XQWnMCgcIyB+cXvx3UdKSK9fdyDrblAM7jBv8UxRgnVVKDkB60HgFpdbM1NJJuvUKrq9PiOKbNPcSZJJ/scvgGV6JXfiSrobkkU9ASmDAgO5+N5delbS6AFfeOujAEq58GsMQZKyhCmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VTGybN7h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VTGybN7h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8966C4CED1; Wed, 4 Dec 2024 03:51:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733284290; bh=bkl1fC1asdNySiWZpwGEDHKtEKnC7uWcPKi06Qhd4pw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VTGybN7huQju9hzuBIgw7miuofMsj6QHx2Wb93mWNe27HTY5EsOAamNaOR9x8lS37 rhu0Q8PlqWujhCl6mwHAVPLL2vIVqzHmHOuuF0i7QQUdLaw6/mW7JIQnJIIasg7eRw QytdcjR8Bg2sVzggbkWNEDJ2/exzmzyp69EdPDrAnQmdE6BXhwVagMuYhvLtKSfjjK SLZgZF+FsHZyfI1SngSonZxlvEqTasQAjYgpy6vn1E/7sEI1CG4rxricqFaAkfX/cO 6jBTbkI70dJQ9xRzqP7/03S63SJIdRA+xPOQLINWuxqy2blrg3X/06if4FwexnKwFF XPK6doEsrLIlw== Date: Tue, 3 Dec 2024 19:51:29 -0800 From: Jakub Kicinski To: Sabrina Dubroca Cc: netdev@vger.kernel.org, Vadim Fedorenko , Frantisek Krenzelok , Kuniyuki Iwashima , Apoorv Kothari , Boris Pismenny , John Fastabend , Shuah Khan , linux-kselftest@vger.kernel.org, Gal Pressman , Marcel Holtmann , Simon Horman Subject: Re: [PATCH net-next v4 4/6] docs: tls: document TLS1.3 key updates Message-ID: <20241203195129.25e07e53@kernel.org> In-Reply-To: <6baaaaf467845c56d7ec47250aaa2138de948003.1731597571.git.sd@queasysnail.net> References: <6baaaaf467845c56d7ec47250aaa2138de948003.1731597571.git.sd@queasysnail.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 14 Nov 2024 16:50:51 +0100 Sabrina Dubroca wrote: > +To prevent attempting to decrypt incoming records using the wrong key, > +decryption will be paused when a KeyUpdate message is received by the > +kernel, until the new key has been provided using the TLS_RX socket > +option. Any read occurring after the KeyUpdate has been read and > +before the new key is provided will fail with EKEYEXPIRED. Poll()'ing > +the socket will also sleep until the new key is provided. There is no > +pausing on the transmit side. Thanks for the doc update, very useful. I'm not a socket expert so dunno if suppressing POLLIN is the right thing to do. But a nit on the phrasing - I'd say "poll() will not report any events from the socket until.." ? Could be just me but sleep is a second order effect.