netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/5] Add support for Priva E-Measuringbox board
@ 2024-12-05 12:56 Oleksij Rempel
  2024-12-05 12:56 ` [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY Oleksij Rempel
                   ` (4 more replies)
  0 siblings, 5 replies; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-05 12:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn
  Cc: Oleksij Rempel, kernel, linux-kernel, netdev, devicetree,
	linux-stm32

This patch series introduces support for the Priva E-Measuringbox board
based on the ST STM32MP133 SoC. The set includes all the necessary
changes for device tree bindings, vendor prefixes, thermal support, and
board-specific devicetree to pass devicetree validation and checkpatch
tests.

Oleksij Rempel (3):
  dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
  dt-bindings: vendor-prefixes: Add prefix for Priva
  dt-bindings: arm: stm32: Add Priva E-Measuringbox board

Roan van Dijk (2):
  arm: dts: stm32: Add thermal support for STM32MP131
  arm: dts: stm32: Add Priva E-Measuringbox devicetree

 .../devicetree/bindings/arm/stm32/stm32.yaml  |   6 +
 .../devicetree/bindings/net/ti,dp83td510.yaml |  35 ++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm/boot/dts/st/Makefile                 |   1 +
 arch/arm/boot/dts/st/stm32mp131.dtsi          |  35 ++
 arch/arm/boot/dts/st/stm32mp133c-prihmb.dts   | 496 ++++++++++++++++++
 6 files changed, 575 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
 create mode 100644 arch/arm/boot/dts/st/stm32mp133c-prihmb.dts

--
2.39.5


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
  2024-12-05 12:56 [PATCH 0/5] Add support for Priva E-Measuringbox board Oleksij Rempel
@ 2024-12-05 12:56 ` Oleksij Rempel
  2024-12-05 17:18   ` Conor Dooley
  2024-12-05 12:56 ` [PATCH v1 2/5] dt-bindings: vendor-prefixes: Add prefix for Priva Oleksij Rempel
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-05 12:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn
  Cc: Oleksij Rempel, kernel, linux-kernel, netdev, devicetree,
	linux-stm32

Introduce devicetree binding for the Texas Instruments DP83TD510
Ultra Low Power 802.3cg 10Base-T1L Single Pair Ethernet PHY.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 .../devicetree/bindings/net/ti,dp83td510.yaml | 35 +++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml

diff --git a/Documentation/devicetree/bindings/net/ti,dp83td510.yaml b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
new file mode 100644
index 000000000000..cf13e86a4017
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/ti,dp83td510.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI DP83TD510 10BaseT1L PHY
+
+maintainers:
+  - Oleksij Rempel <o.rempel@pengutronix.de>
+
+description:
+  DP83TD510E Ultra Low Power 802.3cg 10Base-T1L 10M Single Pair Ethernet PHY
+
+allOf:
+  - $ref: ethernet-phy.yaml#
+
+properties:
+  compatible:
+    enum:
+      - ethernet-phy-id2000.0181
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    mdio {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethernet-phy@0 {
+            compatible = "ethernet-phy-id2000.0181";
+            reg = <0>;
+        };
+    };
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v1 2/5] dt-bindings: vendor-prefixes: Add prefix for Priva
  2024-12-05 12:56 [PATCH 0/5] Add support for Priva E-Measuringbox board Oleksij Rempel
  2024-12-05 12:56 ` [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY Oleksij Rempel
@ 2024-12-05 12:56 ` Oleksij Rempel
  2024-12-05 17:16   ` Conor Dooley
  2024-12-05 12:56 ` [PATCH v1 3/5] dt-bindings: arm: stm32: Add Priva E-Measuringbox board Oleksij Rempel
                   ` (2 subsequent siblings)
  4 siblings, 1 reply; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-05 12:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn
  Cc: Oleksij Rempel, kernel, linux-kernel, netdev, devicetree,
	linux-stm32

Introduce the 'pri' vendor prefix for Priva, a company specializing in
sustainable solutions for building automation, energy, and climate
control.  More information about Priva can be found at
https://www.priva.com

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index da01616802c7..9a9ac3adc5ef 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -1198,6 +1198,8 @@ patternProperties:
     description: Primux Trading, S.L.
   "^probox2,.*":
     description: PROBOX2 (by W2COMP Co., Ltd.)
+  "^pri,.*":
+    description: Priva
   "^prt,.*":
     description: Protonic Holland
   "^pulsedlight,.*":
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v1 3/5] dt-bindings: arm: stm32: Add Priva E-Measuringbox board
  2024-12-05 12:56 [PATCH 0/5] Add support for Priva E-Measuringbox board Oleksij Rempel
  2024-12-05 12:56 ` [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY Oleksij Rempel
  2024-12-05 12:56 ` [PATCH v1 2/5] dt-bindings: vendor-prefixes: Add prefix for Priva Oleksij Rempel
@ 2024-12-05 12:56 ` Oleksij Rempel
  2024-12-05 12:56 ` [PATCH v1 4/5] arm: dts: stm32: Add thermal support for STM32MP131 Oleksij Rempel
  2024-12-05 12:56 ` [PATCH v1 5/5] arm: dts: stm32: Add Priva E-Measuringbox devicetree Oleksij Rempel
  4 siblings, 0 replies; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-05 12:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn
  Cc: Oleksij Rempel, kernel, linux-kernel, netdev, devicetree,
	linux-stm32

Add support for the Priva E-Measuringbox ('pri,prihmb') board based on
the ST STM32MP133 SoC to the STM32 devicetree bindings.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 Documentation/devicetree/bindings/arm/stm32/stm32.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
index 703d4b574398..1e27b2bd7c6a 100644
--- a/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
+++ b/Documentation/devicetree/bindings/arm/stm32/stm32.yaml
@@ -51,6 +51,12 @@ properties:
               - st,stm32mp135f-dk
           - const: st,stm32mp135
 
+      - description: ST STM32MP133 based Boards
+        items:
+          - enum:
+              - pri,prihmb   # Priva E-Measuringbox board
+          - const: st,stm32mp133
+
       - description: ST STM32MP151 based Boards
         items:
           - enum:
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v1 4/5] arm: dts: stm32: Add thermal support for STM32MP131
  2024-12-05 12:56 [PATCH 0/5] Add support for Priva E-Measuringbox board Oleksij Rempel
                   ` (2 preceding siblings ...)
  2024-12-05 12:56 ` [PATCH v1 3/5] dt-bindings: arm: stm32: Add Priva E-Measuringbox board Oleksij Rempel
@ 2024-12-05 12:56 ` Oleksij Rempel
  2024-12-05 12:56 ` [PATCH v1 5/5] arm: dts: stm32: Add Priva E-Measuringbox devicetree Oleksij Rempel
  4 siblings, 0 replies; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-05 12:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn
  Cc: Roan van Dijk, Oleksij Rempel, kernel, linux-kernel, netdev,
	devicetree, linux-stm32

From: Roan van Dijk <roan@protonic.nl>

Add thermal zone configuration and sensor node for STM32MP131 SoC.

Signed-off-by: Roan van Dijk <roan@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/st/stm32mp131.dtsi | 35 ++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi
index e1a764d269d2..56660e67a2a2 100644
--- a/arch/arm/boot/dts/st/stm32mp131.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp131.dtsi
@@ -100,6 +100,31 @@ timer {
 		always-on;
 	};
 
+	thermal-zones {
+		cpu_thermal: cpu-thermal {
+			polling-delay-passive = <0>;
+			polling-delay = <0>;
+			thermal-sensors = <&dts>;
+
+			trips {
+				cpu_alert1: cpu-alert1 {
+					temperature = <85000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+
+				cpu-crit {
+					temperature = <120000>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+			};
+
+			cooling-maps {
+			};
+		};
+	};
+
 	soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
@@ -909,6 +934,16 @@ timer {
 			};
 		};
 
+		dts: thermal@50028000 {
+			compatible = "st,stm32-thermal";
+			reg = <0x50028000 0x100>;
+			interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&rcc DTS>;
+			clock-names = "pclk";
+			#thermal-sensor-cells = <0>;
+			status = "disabled";
+		};
+
 		mdma: dma-controller@58000000 {
 			compatible = "st,stm32h7-mdma";
 			reg = <0x58000000 0x1000>;
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [PATCH v1 5/5] arm: dts: stm32: Add Priva E-Measuringbox devicetree
  2024-12-05 12:56 [PATCH 0/5] Add support for Priva E-Measuringbox board Oleksij Rempel
                   ` (3 preceding siblings ...)
  2024-12-05 12:56 ` [PATCH v1 4/5] arm: dts: stm32: Add thermal support for STM32MP131 Oleksij Rempel
@ 2024-12-05 12:56 ` Oleksij Rempel
  4 siblings, 0 replies; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-05 12:56 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn
  Cc: Roan van Dijk, Oleksij Rempel, kernel, linux-kernel, netdev,
	devicetree, linux-stm32

From: Roan van Dijk <roan@protonic.nl>

Introduce the devicetree for the Priva E-Measuringbox board
(stm32mp133c-prihmb), based on the STM32MP133 SoC.

Signed-off-by: Roan van Dijk <roan@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/st/Makefile               |   1 +
 arch/arm/boot/dts/st/stm32mp133c-prihmb.dts | 496 ++++++++++++++++++++
 2 files changed, 497 insertions(+)
 create mode 100644 arch/arm/boot/dts/st/stm32mp133c-prihmb.dts

diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile
index eab3a9bd435f..c4c01415fa85 100644
--- a/arch/arm/boot/dts/st/Makefile
+++ b/arch/arm/boot/dts/st/Makefile
@@ -29,6 +29,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
 	stm32h743i-eval.dtb \
 	stm32h743i-disco.dtb \
 	stm32h750i-art-pi.dtb \
+	stm32mp133c-prihmb.dtb \
 	stm32mp135f-dhcor-dhsbc.dtb \
 	stm32mp135f-dk.dtb \
 	stm32mp151a-prtt1a.dtb \
diff --git a/arch/arm/boot/dts/st/stm32mp133c-prihmb.dts b/arch/arm/boot/dts/st/stm32mp133c-prihmb.dts
new file mode 100644
index 000000000000..663b6de1b814
--- /dev/null
+++ b/arch/arm/boot/dts/st/stm32mp133c-prihmb.dts
@@ -0,0 +1,496 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/regulator/st,stm32mp13-regulator.h>
+#include "stm32mp133.dtsi"
+#include "stm32mp13xc.dtsi"
+#include "stm32mp13-pinctrl.dtsi"
+
+/ {
+	model = "Priva E-Measuringbox board";
+	compatible = "pri,prihmb", "st,stm32mp133";
+
+	aliases {
+		ethernet0 = &ethernet1;
+		mdio-gpio0 = &mdio0;
+		mmc0 = &sdmmc1;
+		mmc1 = &sdmmc2;
+		serial0 = &uart4;
+		serial1 = &usart6;
+		serial2 = &uart7;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
+	counter-0 {
+		compatible = "interrupt-counter";
+		gpios = <&gpioa 11 GPIO_ACTIVE_HIGH>;
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		autorepeat;
+
+		button-reset {
+			label = "reset-button";
+			linux,code = <BTN_1>;
+			gpios = <&gpioi 7 GPIO_ACTIVE_LOW>;
+		};
+	};
+
+	leds {
+		compatible = "gpio-leds";
+
+		led-blue {
+			function = LED_FUNCTION_HEARTBEAT;
+			color = <LED_COLOR_ID_BLUE>;
+			gpios = <&gpioa 14 GPIO_ACTIVE_LOW>;
+			linux,default-trigger = "heartbeat";
+			default-state = "off";
+		};
+	};
+
+	led-controller-0 {
+		compatible = "pwm-leds-multicolor";
+
+		multi-led {
+			color = <LED_COLOR_ID_RGB>;
+			function = LED_FUNCTION_STATUS;
+			max-brightness = <255>;
+
+			led-red {
+				active-low;
+				color = <LED_COLOR_ID_RED>;
+				pwms = <&pwm2 2 1000000 1>;
+			};
+
+			led-green {
+				active-low;
+				color = <LED_COLOR_ID_GREEN>;
+				pwms = <&pwm1 1 1000000 1>;
+			};
+
+			led-blue {
+				active-low;
+				color = <LED_COLOR_ID_BLUE>;
+				pwms = <&pwm1 2 1000000 1>;
+			};
+		};
+	};
+
+	led-controller-1 {
+		compatible = "pwm-leds-multicolor";
+
+		multi-led {
+			color = <LED_COLOR_ID_RGB>;
+			function = LED_FUNCTION_STATUS;
+			max-brightness = <255>;
+
+			led-red {
+				active-low;
+				color = <LED_COLOR_ID_RED>;
+				pwms = <&pwm1 0 1000000 1>;
+			};
+
+			led-green {
+				active-low;
+				color = <LED_COLOR_ID_GREEN>;
+				pwms = <&pwm2 0 1000000 1>;
+			};
+
+			led-blue {
+				active-low;
+				color = <LED_COLOR_ID_BLUE>;
+				pwms = <&pwm2 1 1000000 1>;
+			};
+		};
+	};
+
+	/* DP83TD510E PHYs have max MDC rate of 1.75MHz. Since we can't reduce
+	 * stmmac MDC clock without reducing system bus rate, we need to use
+	 * gpio based MDIO bus.
+	 */
+	mdio0: mdio {
+		compatible = "virtual,mdio-gpio";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		gpios = <&gpiog 2 GPIO_ACTIVE_HIGH
+			 &gpioa 2 GPIO_ACTIVE_HIGH>;
+
+		/* TI DP83TD510E */
+		phy0: ethernet-phy@0 {
+			compatible = "ethernet-phy-id2000.0181";
+			reg = <0>;
+			interrupts-extended = <&gpioa 4 IRQ_TYPE_LEVEL_LOW>;
+			reset-gpios = <&gpioa 3 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <10>;
+			reset-deassert-us = <35>;
+		};
+	};
+
+	memory@c0000000 {
+		device_type = "memory";
+		reg = <0xc0000000 0x10000000>;
+	};
+
+	reg_3v3: regulator-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "3v3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		optee@ce000000 {
+			reg = <0xce000000 0x02000000>;
+			no-map;
+		};
+	};
+};
+
+&adc_1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&adc_1_pins_a>;
+	vdda-supply = <&reg_3v3>;
+	vref-supply = <&reg_3v3>;
+	status = "okay";
+};
+
+&adc1 {
+	status = "okay";
+
+	channel@0 { /* Fan current PC0*/
+		reg = <0>;
+		st,min-sample-time-ns = <10000>;  /* 10µs sampling time */
+	};
+	channel@11 { /* Fan voltage */
+		reg = <11>;
+		st,min-sample-time-ns = <10000>;  /* 10µs sampling time */
+	};
+	channel@15 { /* Supply voltage */
+		reg = <15>;
+		st,min-sample-time-ns = <10000>;  /* 10µs sampling time */
+	};
+};
+
+&dts {
+	status = "okay";
+};
+
+&ethernet1 {
+	status = "okay";
+	pinctrl-0 = <&ethernet1_rmii_pins_a>;
+	pinctrl-1 = <&ethernet1_rmii_sleep_pins_a>;
+	pinctrl-names = "default", "sleep";
+	phy-mode = "rmii";
+	phy-handle = <&phy0>;
+};
+
+&i2c1 {
+	pinctrl-names = "default", "sleep";
+	pinctrl-0 = <&i2c1_pins_a>;
+	pinctrl-1 = <&i2c1_sleep_pins_a>;
+	clock-frequency = <100000>;
+	/delete-property/dmas;
+	/delete-property/dma-names;
+	status = "okay";
+
+	board-sensor@48 {
+		compatible = "ti,tmp1075";
+		reg = <0x48>;
+		vs-supply = <&reg_3v3>;
+	};
+};
+
+&{i2c1_pins_a/pins} {
+	pinmux = <STM32_PINMUX('D', 3, AF5)>, /* I2C1_SCL */
+		 <STM32_PINMUX('B', 8, AF4)>; /* I2C1_SDA */
+	bias-disable;
+	drive-open-drain;
+	slew-rate = <0>;
+};
+
+&{i2c1_sleep_pins_a/pins} {
+	pinmux = <STM32_PINMUX('D', 3, ANALOG)>, /* I2C1_SCL */
+		 <STM32_PINMUX('B', 8, ANALOG)>; /* I2C1_SDA */
+};
+
+&iwdg2 {
+	timeout-sec = <32>;
+	status = "okay";
+};
+
+/* SD card without Card-detect */
+&sdmmc1 {
+	pinctrl-names = "default", "opendrain", "sleep";
+	pinctrl-0 = <&sdmmc1_b4_pins_a &sdmmc1_clk_pins_a>;
+	pinctrl-1 = <&sdmmc1_b4_od_pins_a &sdmmc1_clk_pins_a>;
+	pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
+	broken-cd;
+	no-sdio;
+	no-1-8-v;
+	st,neg-edge;
+	bus-width = <4>;
+	vmmc-supply = <&reg_3v3>;
+	status = "okay";
+};
+
+/* EMMC */
+&sdmmc2 {
+	pinctrl-names = "default", "opendrain", "sleep";
+	pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a &sdmmc2_clk_pins_a>;
+	pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_a &sdmmc2_clk_pins_a>;
+	pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_a>;
+	non-removable;
+	no-sd;
+	no-sdio;
+	no-1-8-v;
+	st,neg-edge;
+	mmc-ddr-3_3v;
+	bus-width = <8>;
+	vmmc-supply = <&reg_3v3>;
+	status = "okay";
+};
+
+&timers1 {
+	status = "okay";
+	/delete-property/dmas;
+	/delete-property/dma-names;
+
+	pwm1: pwm {
+		pinctrl-0 = <&pwm1_pins_a>;
+		pinctrl-1 = <&pwm1_sleep_pins_a>;
+		pinctrl-names = "default", "sleep";
+		status = "okay";
+	};
+};
+
+&timers4 {
+	status = "okay";
+	/delete-property/dmas;
+	/delete-property/dma-names;
+
+	pwm2: pwm {
+		pinctrl-0 = <&pwm4_pins_a>;
+		pinctrl-1 = <&pwm4_sleep_pins_a>;
+		pinctrl-names = "default", "sleep";
+		status = "okay";
+	};
+};
+
+/* Fan PWM */
+&timers5 {
+	status = "okay";
+
+	pwm3: pwm {
+		pinctrl-0 = <&pwm5_pins_a>;
+		pinctrl-1 = <&pwm5_sleep_pins_a>;
+		pinctrl-names = "default", "sleep";
+		status = "okay";
+	};
+};
+
+&timers2 {
+	status = "okay";
+
+	timer@1 {
+		status = "okay";
+	};
+};
+
+&uart4 {
+	pinctrl-names = "default", "sleep", "idle";
+	pinctrl-0 = <&uart4_pins_a>;
+	pinctrl-1 = <&uart4_sleep_pins_a>;
+	pinctrl-2 = <&uart4_idle_pins_a>;
+	/delete-property/dmas;
+	/delete-property/dma-names;
+	status = "okay";
+};
+
+&uart7 {
+	pinctrl-names = "default", "sleep", "idle";
+	pinctrl-0 = <&uart7_pins_a>;
+	pinctrl-1 = <&uart7_sleep_pins_a>;
+	pinctrl-2 = <&uart7_idle_pins_a>;
+	/delete-property/dmas;
+	/delete-property/dma-names;
+	status = "okay";
+};
+
+&usart6 {
+	pinctrl-names = "default", "sleep", "idle";
+	pinctrl-0 = <&usart6_pins_a>;
+	pinctrl-1 = <&usart6_sleep_pins_a>;
+	pinctrl-2 = <&usart6_idle_pins_a>;
+	linux,rs485-enabled-at-boot-time;
+	/delete-property/dmas;
+	/delete-property/dma-names;
+	status = "okay";
+};
+
+&pinctrl {
+	adc_1_pins_a: adc1-0 {
+		pins {
+			pinmux = <STM32_PINMUX('C', 0, ANALOG)>, /* ADC1 in0 */
+				 <STM32_PINMUX('C', 2, ANALOG)>, /* ADC1 in15 */
+				 <STM32_PINMUX('F', 13, ANALOG)>; /* ADC1 in11 */
+		};
+	};
+
+	ethernet1_rmii_pins_a: rmii-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('G', 13, AF11)>, /* ETH1_RMII_TXD0 */
+				 <STM32_PINMUX('G', 14, AF11)>, /* ETH1_RMII_TXD1 */
+				 <STM32_PINMUX('B', 11, AF11)>, /* ETH1_RMII_TX_EN */
+				 <STM32_PINMUX('A', 1, AF11)>;   /* ETH1_RMII_REF_CLK */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <2>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('C', 4, AF11)>,  /* ETH1_RMII_RXD0 */
+				 <STM32_PINMUX('C', 5, AF11)>,  /* ETH1_RMII_RXD1 */
+				 <STM32_PINMUX('A', 7, AF11)>;  /* ETH1_RMII_CRS_DV */
+			bias-disable;
+		};
+	};
+
+	ethernet1_rmii_sleep_pins_a: rmii-sleep-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('G', 13, ANALOG)>, /* ETH1_RMII_TXD0 */
+				 <STM32_PINMUX('G', 14, ANALOG)>, /* ETH1_RMII_TXD1 */
+				 <STM32_PINMUX('B', 11, ANALOG)>, /* ETH1_RMII_TX_EN */
+				 <STM32_PINMUX('C', 4, ANALOG)>,  /* ETH1_RMII_RXD0 */
+				 <STM32_PINMUX('C', 5, ANALOG)>,  /* ETH1_RMII_RXD1 */
+				 <STM32_PINMUX('A', 1, ANALOG)>,  /* ETH1_RMII_REF_CLK */
+				 <STM32_PINMUX('A', 7, ANALOG)>;  /* ETH1_RMII_CRS_DV */
+		};
+	};
+
+	pwm1_pins_a: pwm1-0 {
+		pins {
+			pinmux = <STM32_PINMUX('E', 9, AF1)>, /* TIM1_CH1 */
+				 <STM32_PINMUX('E', 11, AF1)>, /* TIM1_CH2 */
+				 <STM32_PINMUX('E', 13, AF1)>; /* TIM1_CH3 */
+			bias-pull-down;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+	};
+
+	pwm1_sleep_pins_a: pwm1-sleep-0 {
+		pins {
+			pinmux = <STM32_PINMUX('E', 9, ANALOG)>, /* TIM1_CH1 */
+				 <STM32_PINMUX('E', 11, ANALOG)>, /* TIM1_CH2 */
+				 <STM32_PINMUX('E', 13, ANALOG)>; /* TIM1_CH3 */
+		};
+	};
+
+	pwm4_pins_a: pwm4-0 {
+		pins {
+			pinmux = <STM32_PINMUX('D', 12, AF2)>, /* TIM4_CH1 */
+				 <STM32_PINMUX('B', 7, AF2)>, /* TIM4_CH2 */
+				 <STM32_PINMUX('D', 14, AF2)>; /* TIM4_CH3 */
+			bias-pull-down;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+	};
+
+	pwm4_sleep_pins_a: pwm4-sleep-0 {
+		pins {
+			pinmux = <STM32_PINMUX('D', 12, ANALOG)>, /* TIM4_CH1 */
+				 <STM32_PINMUX('B', 7, ANALOG)>, /* TIM4_CH2 */
+				 <STM32_PINMUX('D', 14, ANALOG)>; /* TIM4_CH3 */
+		};
+	};
+	pwm5_pins_a: pwm5-0 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 0, AF2)>; /* TIM5_CH1 */
+		};
+	};
+
+	pwm5_sleep_pins_a: pwm5-sleep-0 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 0, ANALOG)>; /* TIM5_CH1 */
+		};
+	};
+
+	uart7_pins_a: uart7-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('E', 8, AF7)>; /* UART_TX */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('E', 10, AF7)>; /* UART7_RX */
+			bias-pull-up;
+		};
+	};
+
+	uart7_idle_pins_a: uart7-idle-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('E', 8, ANALOG)>; /* UART7_TX */
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('E', 10, AF7)>; /* UART7_RX */
+			bias-pull-up;
+		};
+	};
+
+	uart7_sleep_pins_a: uart7-sleep-0 {
+		pins {
+			pinmux = <STM32_PINMUX('E', 8, ANALOG)>, /* UART7_TX */
+				 <STM32_PINMUX('E', 10, ANALOG)>; /* UART7_RX */
+		};
+	};
+
+	usart6_pins_a: usart6-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('F', 8, AF7)>, /* USART6_TX */
+				 <STM32_PINMUX('F', 10, AF7)>; /* USART6_DE */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('H', 11, AF7)>; /* USART6_RX */
+			bias-disable;
+		};
+	};
+
+	usart6_idle_pins_a: usart6-idle-0 {
+		pins1 {
+			pinmux = <STM32_PINMUX('F', 8, ANALOG)>; /* USART6_TX */
+		};
+		pins2 {
+			pinmux = <STM32_PINMUX('F', 10, AF7)>; /* USART6_DE */
+			bias-disable;
+			drive-push-pull;
+			slew-rate = <0>;
+		};
+		pins3 {
+			pinmux = <STM32_PINMUX('H', 11, AF7)>; /* USART6_RX */
+			bias-disable;
+		};
+	};
+
+	usart6_sleep_pins_a: usart6-sleep-0 {
+		pins {
+			pinmux = <STM32_PINMUX('F', 8, ANALOG)>, /* USART6_TX */
+				 <STM32_PINMUX('F', 10, ANALOG)>, /* USART6_DE */
+				 <STM32_PINMUX('H', 11, ANALOG)>; /* USART6_RX */
+		};
+	};
+};
-- 
2.39.5


^ permalink raw reply related	[flat|nested] 14+ messages in thread

* Re: [PATCH v1 2/5] dt-bindings: vendor-prefixes: Add prefix for Priva
  2024-12-05 12:56 ` [PATCH v1 2/5] dt-bindings: vendor-prefixes: Add prefix for Priva Oleksij Rempel
@ 2024-12-05 17:16   ` Conor Dooley
  2024-12-06  6:13     ` Oleksij Rempel
  0 siblings, 1 reply; 14+ messages in thread
From: Conor Dooley @ 2024-12-05 17:16 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn, kernel, linux-kernel,
	netdev, devicetree, linux-stm32

[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]

On Thu, Dec 05, 2024 at 01:56:37PM +0100, Oleksij Rempel wrote:
> Introduce the 'pri' vendor prefix for Priva, a company specializing in
> sustainable solutions for building automation, energy, and climate
> control.  More information about Priva can be found at
> https://www.priva.com
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index da01616802c7..9a9ac3adc5ef 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -1198,6 +1198,8 @@ patternProperties:
>      description: Primux Trading, S.L.
>    "^probox2,.*":
>      description: PROBOX2 (by W2COMP Co., Ltd.)
> +  "^pri,.*":
> +    description: Priva

Why not "priva"? Saving two chars doesn't seem worth less info.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
  2024-12-05 12:56 ` [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY Oleksij Rempel
@ 2024-12-05 17:18   ` Conor Dooley
  2024-12-06  8:10     ` Oleksij Rempel
  0 siblings, 1 reply; 14+ messages in thread
From: Conor Dooley @ 2024-12-05 17:18 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn, kernel, linux-kernel,
	netdev, devicetree, linux-stm32

[-- Attachment #1: Type: text/plain, Size: 1723 bytes --]

On Thu, Dec 05, 2024 at 01:56:36PM +0100, Oleksij Rempel wrote:
> Introduce devicetree binding for the Texas Instruments DP83TD510
> Ultra Low Power 802.3cg 10Base-T1L Single Pair Ethernet PHY.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../devicetree/bindings/net/ti,dp83td510.yaml | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83td510.yaml b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> new file mode 100644
> index 000000000000..cf13e86a4017
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/ti,dp83td510.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI DP83TD510 10BaseT1L PHY
> +
> +maintainers:
> +  - Oleksij Rempel <o.rempel@pengutronix.de>
> +
> +description:
> +  DP83TD510E Ultra Low Power 802.3cg 10Base-T1L 10M Single Pair Ethernet PHY
> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ethernet-phy-id2000.0181

There's nothing specific here, can someone remind me why the generic
binding is not enough?

> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    mdio {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet-phy@0 {
> +            compatible = "ethernet-phy-id2000.0181";
> +            reg = <0>;
> +        };
> +    };
> -- 
> 2.39.5
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v1 2/5] dt-bindings: vendor-prefixes: Add prefix for Priva
  2024-12-05 17:16   ` Conor Dooley
@ 2024-12-06  6:13     ` Oleksij Rempel
  2024-12-06 16:53       ` Conor Dooley
  0 siblings, 1 reply; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-06  6:13 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Woojung Huh, Rob Herring, Conor Dooley, kernel, devicetree,
	netdev, linux-stm32, Alexandre Torgue, linux-kernel, Andrew Lunn,
	Eric Dumazet, Maxime Coquelin, Jakub Kicinski,
	Krzysztof Kozlowski, Paolo Abeni, David S. Miller

On Thu, Dec 05, 2024 at 05:16:14PM +0000, Conor Dooley wrote:
> On Thu, Dec 05, 2024 at 01:56:37PM +0100, Oleksij Rempel wrote:
> > Introduce the 'pri' vendor prefix for Priva, a company specializing in
> > sustainable solutions for building automation, energy, and climate
> > control.  More information about Priva can be found at
> > https://www.priva.com
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index da01616802c7..9a9ac3adc5ef 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -1198,6 +1198,8 @@ patternProperties:
> >      description: Primux Trading, S.L.
> >    "^probox2,.*":
> >      description: PROBOX2 (by W2COMP Co., Ltd.)
> > +  "^pri,.*":
> > +    description: Priva
> 
> Why not "priva"? Saving two chars doesn't seem worth less info.

This is typical prefix which is used by this vendor, if it is possible
i would prefer not to change it. But, last decision is on your side :)

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
  2024-12-05 17:18   ` Conor Dooley
@ 2024-12-06  8:10     ` Oleksij Rempel
  2024-12-06 16:57       ` Conor Dooley
  0 siblings, 1 reply; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-06  8:10 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn, kernel, linux-kernel,
	netdev, devicetree, linux-stm32

On Thu, Dec 05, 2024 at 05:18:59PM +0000, Conor Dooley wrote:
> On Thu, Dec 05, 2024 at 01:56:36PM +0100, Oleksij Rempel wrote:
> > Introduce devicetree binding for the Texas Instruments DP83TD510
> > Ultra Low Power 802.3cg 10Base-T1L Single Pair Ethernet PHY.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  .../devicetree/bindings/net/ti,dp83td510.yaml | 35 +++++++++++++++++++
> >  1 file changed, 35 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/net/ti,dp83td510.yaml b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > new file mode 100644
> > index 000000000000..cf13e86a4017
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > @@ -0,0 +1,35 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/ti,dp83td510.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: TI DP83TD510 10BaseT1L PHY
> > +
> > +maintainers:
> > +  - Oleksij Rempel <o.rempel@pengutronix.de>
> > +
> > +description:
> > +  DP83TD510E Ultra Low Power 802.3cg 10Base-T1L 10M Single Pair Ethernet PHY
> > +
> > +allOf:
> > +  - $ref: ethernet-phy.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - ethernet-phy-id2000.0181
> 
> There's nothing specific here, can someone remind me why the generic
> binding is not enough?

The missing binding was blamed by checkpatch. Haw should I proceed with this
patch?

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v1 2/5] dt-bindings: vendor-prefixes: Add prefix for Priva
  2024-12-06  6:13     ` Oleksij Rempel
@ 2024-12-06 16:53       ` Conor Dooley
  0 siblings, 0 replies; 14+ messages in thread
From: Conor Dooley @ 2024-12-06 16:53 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Woojung Huh, Rob Herring, Conor Dooley, kernel, devicetree,
	netdev, linux-stm32, Alexandre Torgue, linux-kernel, Andrew Lunn,
	Eric Dumazet, Maxime Coquelin, Jakub Kicinski,
	Krzysztof Kozlowski, Paolo Abeni, David S. Miller

[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]

On Fri, Dec 06, 2024 at 07:13:09AM +0100, Oleksij Rempel wrote:
> On Thu, Dec 05, 2024 at 05:16:14PM +0000, Conor Dooley wrote:
> > On Thu, Dec 05, 2024 at 01:56:37PM +0100, Oleksij Rempel wrote:
> > > Introduce the 'pri' vendor prefix for Priva, a company specializing in
> > > sustainable solutions for building automation, energy, and climate
> > > control.  More information about Priva can be found at
> > > https://www.priva.com
> > > 
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > > index da01616802c7..9a9ac3adc5ef 100644
> > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > > @@ -1198,6 +1198,8 @@ patternProperties:
> > >      description: Primux Trading, S.L.
> > >    "^probox2,.*":
> > >      description: PROBOX2 (by W2COMP Co., Ltd.)
> > > +  "^pri,.*":
> > > +    description: Priva
> > 
> > Why not "priva"? Saving two chars doesn't seem worth less info.
> 
> This is typical prefix which is used by this vendor, if it is possible
> i would prefer not to change it. But, last decision is on your side :)

I dunno, think if I was being unreasonable like that people would tell
me where to go.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
  2024-12-06  8:10     ` Oleksij Rempel
@ 2024-12-06 16:57       ` Conor Dooley
  2024-12-07  8:00         ` Oleksij Rempel
  0 siblings, 1 reply; 14+ messages in thread
From: Conor Dooley @ 2024-12-06 16:57 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn, kernel, linux-kernel,
	netdev, devicetree, linux-stm32

[-- Attachment #1: Type: text/plain, Size: 2012 bytes --]

On Fri, Dec 06, 2024 at 09:10:14AM +0100, Oleksij Rempel wrote:
> On Thu, Dec 05, 2024 at 05:18:59PM +0000, Conor Dooley wrote:
> > On Thu, Dec 05, 2024 at 01:56:36PM +0100, Oleksij Rempel wrote:
> > > Introduce devicetree binding for the Texas Instruments DP83TD510
> > > Ultra Low Power 802.3cg 10Base-T1L Single Pair Ethernet PHY.
> > > 
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > >  .../devicetree/bindings/net/ti,dp83td510.yaml | 35 +++++++++++++++++++
> > >  1 file changed, 35 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/net/ti,dp83td510.yaml b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > new file mode 100644
> > > index 000000000000..cf13e86a4017
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > @@ -0,0 +1,35 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/net/ti,dp83td510.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: TI DP83TD510 10BaseT1L PHY
> > > +
> > > +maintainers:
> > > +  - Oleksij Rempel <o.rempel@pengutronix.de>
> > > +
> > > +description:
> > > +  DP83TD510E Ultra Low Power 802.3cg 10Base-T1L 10M Single Pair Ethernet PHY
> > > +
> > > +allOf:
> > > +  - $ref: ethernet-phy.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - ethernet-phy-id2000.0181
> > 
> > There's nothing specific here, can someone remind me why the generic
> > binding is not enough?
> 
> The missing binding was blamed by checkpatch. Haw should I proceed with this
> patch?

Does dtbs_check complain when you use it in a dts? What you have here
matches against the pattern ^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$
so I think it won't. checkpatch might be too dumb to evaluate the regex?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
  2024-12-06 16:57       ` Conor Dooley
@ 2024-12-07  8:00         ` Oleksij Rempel
  2024-12-09  9:52           ` Krzysztof Kozlowski
  0 siblings, 1 reply; 14+ messages in thread
From: Oleksij Rempel @ 2024-12-07  8:00 UTC (permalink / raw)
  To: Conor Dooley
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
	Alexandre Torgue, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Woojung Huh, Andrew Lunn, kernel, linux-kernel,
	netdev, devicetree, linux-stm32

On Fri, Dec 06, 2024 at 04:57:01PM +0000, Conor Dooley wrote:
> On Fri, Dec 06, 2024 at 09:10:14AM +0100, Oleksij Rempel wrote:
> > On Thu, Dec 05, 2024 at 05:18:59PM +0000, Conor Dooley wrote:
> > > On Thu, Dec 05, 2024 at 01:56:36PM +0100, Oleksij Rempel wrote:
> > > > Introduce devicetree binding for the Texas Instruments DP83TD510
> > > > Ultra Low Power 802.3cg 10Base-T1L Single Pair Ethernet PHY.
> > > > 
> > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > > ---
> > > >  .../devicetree/bindings/net/ti,dp83td510.yaml | 35 +++++++++++++++++++
> > > >  1 file changed, 35 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/net/ti,dp83td510.yaml b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > > new file mode 100644
> > > > index 000000000000..cf13e86a4017
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/net/ti,dp83td510.yaml
> > > > @@ -0,0 +1,35 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/net/ti,dp83td510.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: TI DP83TD510 10BaseT1L PHY
> > > > +
> > > > +maintainers:
> > > > +  - Oleksij Rempel <o.rempel@pengutronix.de>
> > > > +
> > > > +description:
> > > > +  DP83TD510E Ultra Low Power 802.3cg 10Base-T1L 10M Single Pair Ethernet PHY
> > > > +
> > > > +allOf:
> > > > +  - $ref: ethernet-phy.yaml#
> > > > +
> > > > +properties:
> > > > +  compatible:
> > > > +    enum:
> > > > +      - ethernet-phy-id2000.0181
> > > 
> > > There's nothing specific here, can someone remind me why the generic
> > > binding is not enough?
> > 
> > The missing binding was blamed by checkpatch. Haw should I proceed with this
> > patch?
> 
> Does dtbs_check complain when you use it in a dts? What you have here
> matches against the pattern ^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$
> so I think it won't. checkpatch might be too dumb to evaluate the regex?

dtbs_check didn't complained about it, only checkpatch.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY
  2024-12-07  8:00         ` Oleksij Rempel
@ 2024-12-09  9:52           ` Krzysztof Kozlowski
  0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-09  9:52 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Conor Dooley, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Maxime Coquelin, Alexandre Torgue, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Woojung Huh, Andrew Lunn, kernel,
	linux-kernel, netdev, devicetree, linux-stm32

On Sat, Dec 07, 2024 at 09:00:32AM +0100, Oleksij Rempel wrote:
> > > > > +properties:
> > > > > +  compatible:
> > > > > +    enum:
> > > > > +      - ethernet-phy-id2000.0181
> > > > 
> > > > There's nothing specific here, can someone remind me why the generic
> > > > binding is not enough?
> > > 
> > > The missing binding was blamed by checkpatch. Haw should I proceed with this
> > > patch?
> > 
> > Does dtbs_check complain when you use it in a dts? What you have here
> > matches against the pattern ^ethernet-phy-id[a-f0-9]{4}\\.[a-f0-9]{4}$
> > so I think it won't. checkpatch might be too dumb to evaluate the regex?
> 
> dtbs_check didn't complained about it, only checkpatch.

Checkpatch is not a reason to add bindings. Missing binding would be a
reason (e.g. pointed out by dtschema), but I understand this is not the
case here, so drop the patch.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-12-09  9:52 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-05 12:56 [PATCH 0/5] Add support for Priva E-Measuringbox board Oleksij Rempel
2024-12-05 12:56 ` [PATCH v1 1/5] dt-bindings: net: Add TI DP83TD510 10BaseT1L PHY Oleksij Rempel
2024-12-05 17:18   ` Conor Dooley
2024-12-06  8:10     ` Oleksij Rempel
2024-12-06 16:57       ` Conor Dooley
2024-12-07  8:00         ` Oleksij Rempel
2024-12-09  9:52           ` Krzysztof Kozlowski
2024-12-05 12:56 ` [PATCH v1 2/5] dt-bindings: vendor-prefixes: Add prefix for Priva Oleksij Rempel
2024-12-05 17:16   ` Conor Dooley
2024-12-06  6:13     ` Oleksij Rempel
2024-12-06 16:53       ` Conor Dooley
2024-12-05 12:56 ` [PATCH v1 3/5] dt-bindings: arm: stm32: Add Priva E-Measuringbox board Oleksij Rempel
2024-12-05 12:56 ` [PATCH v1 4/5] arm: dts: stm32: Add thermal support for STM32MP131 Oleksij Rempel
2024-12-05 12:56 ` [PATCH v1 5/5] arm: dts: stm32: Add Priva E-Measuringbox devicetree Oleksij Rempel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).