From: Simon Horman <horms@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, shenjian15@huawei.com,
wangpeiyang1@huawei.com, liuyonglong@huawei.com,
chenhao418@huawei.com, sudongming1@huawei.com,
xujunsheng@huawei.com, shiyongbang@huawei.com,
libaihan@huawei.com, jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hkelam@marvell.com
Subject: Re: [PATCH V4 RESEND net-next 2/7] net: hibmcge: Add irq_info file to debugfs
Date: Thu, 5 Dec 2024 16:25:37 +0000 [thread overview]
Message-ID: <20241205162537.GB2581@kernel.org> (raw)
In-Reply-To: <20241203150131.3139399-3-shaojijie@huawei.com>
On Tue, Dec 03, 2024 at 11:01:26PM +0800, Jijie Shao wrote:
> the driver requested three interrupts: "tx", "rx", "err".
> The err interrupt is a summary interrupt. We distinguish
> different errors based on the status register and mask.
>
> With "cat /proc/interrupts | grep hibmcge",
> we can't distinguish the detailed cause of the error,
> so we added this file to debugfs.
>
> the following effects are achieved:
> [root@localhost sjj]# cat /sys/kernel/debug/hibmcge/0000\:83\:00.1/irq_info
> RX : enabled: true , logged: false, count: 0
> TX : enabled: true , logged: false, count: 0
> MAC_MII_FIFO_ERR : enabled: false, logged: true , count: 0
> MAC_PCS_RX_FIFO_ERR : enabled: false, logged: true , count: 0
> MAC_PCS_TX_FIFO_ERR : enabled: false, logged: true , count: 0
> MAC_APP_RX_FIFO_ERR : enabled: false, logged: true , count: 0
> MAC_APP_TX_FIFO_ERR : enabled: false, logged: true , count: 0
> SRAM_PARITY_ERR : enabled: true , logged: true , count: 0
> TX_AHB_ERR : enabled: true , logged: true , count: 0
> RX_BUF_AVL : enabled: true , logged: false, count: 0
> REL_BUF_ERR : enabled: true , logged: true , count: 0
> TXCFG_AVL : enabled: true , logged: false, count: 0
> TX_DROP : enabled: true , logged: false, count: 0
> RX_DROP : enabled: true , logged: false, count: 0
> RX_AHB_ERR : enabled: true , logged: true , count: 0
> MAC_FIFO_ERR : enabled: true , logged: false, count: 0
> RBREQ_ERR : enabled: true , logged: false, count: 0
> WE_ERR : enabled: true , logged: false, count: 0
>
> The irq framework of hibmcge driver also includes tx/rx interrupts.
> Therefore, TX and RX are not moved separately form this file.
>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-12-05 16:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 15:01 [PATCH V4 RESEND net-next 0/7] Support some features for the HIBMCGE driver Jijie Shao
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 1/7] net: hibmcge: Add debugfs supported in this module Jijie Shao
2024-12-05 16:21 ` Simon Horman
2024-12-06 1:50 ` Jakub Kicinski
2024-12-06 2:28 ` Jijie Shao
2024-12-06 6:23 ` Greg Kroah-Hartman
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 2/7] net: hibmcge: Add irq_info file to debugfs Jijie Shao
2024-12-05 16:25 ` Simon Horman [this message]
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 3/7] net: hibmcge: Add unicast frame filter supported in this module Jijie Shao
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 4/7] net: hibmcge: Add register dump " Jijie Shao
2024-12-05 16:34 ` Simon Horman
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 5/7] net: hibmcge: Add pauseparam " Jijie Shao
2024-12-03 20:50 ` Andrew Lunn
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 6/7] net: hibmcge: Add reset " Jijie Shao
2024-12-05 16:33 ` Simon Horman
2024-12-06 1:59 ` Jakub Kicinski
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 7/7] net: hibmcge: Add nway_reset " Jijie Shao
2024-12-03 20:52 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205162537.GB2581@kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).