Re: [PATCH V4 RESEND net-next 4/7] net: hibmcge: Add register dump supported in this module

[Simon Horman <horms@kernel.org>]

On Tue, Dec 03, 2024 at 11:01:28PM +0800, Jijie Shao wrote:
> The dump register is an effective way to analyze problems.
> 
> To ensure code flexibility, each register contains the type,
> offset, and value information. The ethtool does the pretty print
> based on these information.
> 
> The driver can dynamically add or delete registers that need to be dumped
> in the future because information such as type and offset is contained.
> ethtool always can do pretty print.
> 
> With the ethtool of a specific version,
> the following effects are achieved:
> [root@localhost sjj]# ./ethtool -d enp131s0f1
> [SPEC] VALID                    [0x0000]: 0x00000001
> [SPEC] EVENT_REQ                [0x0004]: 0x00000000
> [SPEC] MAC_ID                   [0x0008]: 0x00000002
> [SPEC] PHY_ADDR                 [0x000c]: 0x00000002
> [SPEC] MAC_ADDR_L               [0x0010]: 0x00000808
> [SPEC] MAC_ADDR_H               [0x0014]: 0x08080802
> [SPEC] UC_MAX_NUM               [0x0018]: 0x00000004
> [SPEC] MAX_MTU                  [0x0028]: 0x00000fc2
> [SPEC] MIN_MTU                  [0x002c]: 0x00000100
> [SPEC] TX_FIFO_NUM              [0x0030]: 0x00000040
> [SPEC] RX_FIFO_NUM              [0x0034]: 0x0000007f
> [SPEC] VLAN_LAYERS              [0x0038]: 0x00000002
> [MDIO] COMMAND_REG              [0x0000]: 0x0000185f
> [MDIO] ADDR_REG                 [0x0004]: 0x00000000
> [MDIO] WDATA_REG                [0x0008]: 0x0000a000
> [MDIO] RDATA_REG                [0x000c]: 0x00000000
> [MDIO] STA_REG                  [0x0010]: 0x00000000
> [GMAC] DUPLEX_TYPE              [0x0008]: 0x00000001
> [GMAC] FD_FC_TYPE               [0x000c]: 0x00008808
> [GMAC] FC_TX_TIMER              [0x001c]: 0x000000ff
> [GMAC] FD_FC_ADDR_LOW           [0x0020]: 0xc2000001
> [GMAC] FD_FC_ADDR_HIGH          [0x0024]: 0x00000180
> [GMAC] MAX_FRM_SIZE             [0x003c]: 0x000005f6
> [GMAC] PORT_MODE                [0x0040]: 0x00000002
> [GMAC] PORT_EN                  [0x0044]: 0x00000006
> ...
> 
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>