From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: [PATCH v1 net-next 10/15] af_unix: Split restart label in unix_dgram_sendmsg().
Date: Fri, 6 Dec 2024 14:26:02 +0900 [thread overview]
Message-ID: <20241206052607.1197-11-kuniyu@amazon.com> (raw)
In-Reply-To: <20241206052607.1197-1-kuniyu@amazon.com>
There are two paths jumping to the restart label in unix_dgram_sendmsg().
One requires another lookup and sk_filter(), but the other doesn't.
Let's split the label to make each flow more straightforward.
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
net/unix/af_unix.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c
index fdcd33b4e0ce..b23d36b049da 100644
--- a/net/unix/af_unix.c
+++ b/net/unix/af_unix.c
@@ -2042,8 +2042,8 @@ static int unix_dgram_sendmsg(struct socket *sock, struct msghdr *msg,
timeo = sock_sndtimeo(sk, msg->msg_flags & MSG_DONTWAIT);
-restart:
if (!other) {
+lookup:
other = unix_find_other(sock_net(sk), msg->msg_name,
msg->msg_namelen, sk->sk_type);
if (IS_ERR(other)) {
@@ -2059,6 +2059,7 @@ static int unix_dgram_sendmsg(struct socket *sock, struct msghdr *msg,
goto out_free;
}
+restart:
sk_locked = 0;
unix_state_lock(other);
restart_locked:
@@ -2106,7 +2107,8 @@ static int unix_dgram_sendmsg(struct socket *sock, struct msghdr *msg,
other = NULL;
if (err)
goto out_free;
- goto restart;
+
+ goto lookup;
}
if (other->sk_shutdown & RCV_SHUTDOWN) {
--
2.39.5 (Apple Git-154)
next prev parent reply other threads:[~2024-12-06 5:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 5:25 [PATCH v1 net-next 00/15] af_unix: Prepare for skb drop reason Kuniyuki Iwashima
2024-12-06 5:25 ` [PATCH v1 net-next 01/15] af_unix: Set error only when needed in unix_stream_connect() Kuniyuki Iwashima
2024-12-06 5:25 ` [PATCH v1 net-next 02/15] af_unix: Clean up error paths " Kuniyuki Iwashima
2024-12-06 5:25 ` [PATCH v1 net-next 03/15] af_unix: Set error only when needed in unix_stream_sendmsg() Kuniyuki Iwashima
2024-12-06 5:25 ` [PATCH v1 net-next 04/15] af_unix: Remove redundant SEND_SHUTDOWN check " Kuniyuki Iwashima
2024-12-10 11:48 ` Paolo Abeni
2024-12-13 8:18 ` Kuniyuki Iwashima
2024-12-06 5:25 ` [PATCH v1 net-next 05/15] af_unix: Clean up error paths " Kuniyuki Iwashima
2024-12-06 5:25 ` [PATCH v1 net-next 06/15] af_unix: Set error only when needed in unix_dgram_sendmsg() Kuniyuki Iwashima
2024-12-06 5:25 ` [PATCH v1 net-next 07/15] af_unix: Call unix_autobind() only when msg_namelen is specified " Kuniyuki Iwashima
2024-12-10 11:11 ` Paolo Abeni
2024-12-10 11:33 ` Kuniyuki Iwashima
2024-12-06 5:26 ` [PATCH v1 net-next 08/15] af_unix: Move !sunaddr case " Kuniyuki Iwashima
2024-12-06 5:26 ` [PATCH v1 net-next 09/15] af_unix: Use msg->{msg_name,msg_namelen} " Kuniyuki Iwashima
2024-12-06 5:26 ` Kuniyuki Iwashima [this message]
2024-12-06 5:26 ` [PATCH v1 net-next 11/15] af_unix: Defer sock_put() to clean up path " Kuniyuki Iwashima
2024-12-06 5:26 ` [PATCH v1 net-next 12/15] af_unix: Clean up SOCK_DEAD error paths " Kuniyuki Iwashima
2024-12-06 5:26 ` [PATCH v1 net-next 13/15] af_unix: Clean up error path " Kuniyuki Iwashima
2024-12-06 5:26 ` [PATCH v1 net-next 14/15] af_unix: Remove sk_locked logic " Kuniyuki Iwashima
2024-12-10 11:42 ` Paolo Abeni
2024-12-13 8:26 ` Kuniyuki Iwashima
2024-12-06 5:26 ` [PATCH v1 net-next 15/15] af_unix: Remove unix_our_peer() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206052607.1197-11-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuni1840@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).