* [PATCH] selftests: net: Fix typo in psock_tpacket.c
@ 2024-12-04 7:57 Zhu Jun
2024-12-06 12:59 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Zhu Jun @ 2024-12-04 7:57 UTC (permalink / raw)
To: davem
Cc: edumazet, kuba, pabeni, shuah, netdev, linux-kselftest,
linux-kernel, zhujun2
The word 'accross' is wrong, so fix it.
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
tools/testing/selftests/net/psock_tpacket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/psock_tpacket.c b/tools/testing/selftests/net/psock_tpacket.c
index 404a2ce75..221270cee 100644
--- a/tools/testing/selftests/net/psock_tpacket.c
+++ b/tools/testing/selftests/net/psock_tpacket.c
@@ -12,7 +12,7 @@
*
* Datapath:
* Open a pair of packet sockets and send resp. receive an a priori known
- * packet pattern accross the sockets and check if it was received resp.
+ * packet pattern across the sockets and check if it was received resp.
* sent correctly. Fanout in combination with RX_RING is currently not
* tested here.
*
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: net: Fix typo in psock_tpacket.c
2024-12-04 7:57 [PATCH] selftests: net: Fix typo in psock_tpacket.c Zhu Jun
@ 2024-12-06 12:59 ` Simon Horman
2024-12-07 1:50 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2024-12-06 12:59 UTC (permalink / raw)
To: Zhu Jun
Cc: davem, edumazet, kuba, pabeni, shuah, netdev, linux-kselftest,
linux-kernel
On Tue, Dec 03, 2024 at 11:57:56PM -0800, Zhu Jun wrote:
> The word 'accross' is wrong, so fix it.
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
> tools/testing/selftests/net/psock_tpacket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/net/psock_tpacket.c b/tools/testing/selftests/net/psock_tpacket.c
> index 404a2ce75..221270cee 100644
> --- a/tools/testing/selftests/net/psock_tpacket.c
> +++ b/tools/testing/selftests/net/psock_tpacket.c
> @@ -12,7 +12,7 @@
> *
> * Datapath:
> * Open a pair of packet sockets and send resp. receive an a priori known
> - * packet pattern accross the sockets and check if it was received resp.
> + * packet pattern across the sockets and check if it was received resp.
> * sent correctly. Fanout in combination with RX_RING is currently not
> * tested here.
> *
Thanks Zhu Jun,
FTR, I'm not sure that I understand the grammar in the comment.
But the spelling correction looks good to me and codespell
doesn't seem to flag any other spelling errors in this file.
So this change looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests: net: Fix typo in psock_tpacket.c
2024-12-06 12:59 ` Simon Horman
@ 2024-12-07 1:50 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2024-12-07 1:50 UTC (permalink / raw)
To: Simon Horman
Cc: Zhu Jun, davem, edumazet, pabeni, shuah, netdev, linux-kselftest,
linux-kernel
On Fri, 6 Dec 2024 12:59:55 +0000 Simon Horman wrote:
> FTR, I'm not sure that I understand the grammar in the comment.
+1
Looks like the author didn't do much due diligence.
--
pw-bot: reject
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-07 1:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 7:57 [PATCH] selftests: net: Fix typo in psock_tpacket.c Zhu Jun
2024-12-06 12:59 ` Simon Horman
2024-12-07 1:50 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).