From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6767217BA5;
	Mon,  9 Dec 2024 21:10:34 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1733778635; cv=none; b=ABeODbmjvacUL5nUZbsK5SclzBYDzVJRpQj2fdwKYOUmsC/P1UBn/w6bEoHN1aPw3R1m7gtuoVotcFZ7cozyZa6OalI9tU35OaGwWSJT8mZkObe5JzPjdzkno+WckyWjDl2AZKAJDK7Yaavrzodne7su/yDyb3Ub2RpLVaGCv6E=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1733778635; c=relaxed/simple;
	bh=FUhkHZk6FYp5UJ7j0cMnzM45fsDiUM3JrC0068ztZ+c=;
	h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:
	 MIME-Version:Content-Type; b=gGrpbUkzGW7NV7ythFPKe/VtftIwktxPMEDzLYm0w1Zqyju91nw8qYSQOU+dGLC+i/itl+/AbJVMAsiZhF8l+9qLdxyS84ckgqR6EJwg6BMz9vty13lPwg2XfKqqer2j7ZP3VASqCKUtmn6reb8FoWUAJJFDtEg2zoUhupRtAl4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uW+EdXEE; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uW+EdXEE"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3D132C4CED1;
	Mon,  9 Dec 2024 21:10:33 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1733778633;
	bh=FUhkHZk6FYp5UJ7j0cMnzM45fsDiUM3JrC0068ztZ+c=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=uW+EdXEE4Lh3ufyYxGNy5xUlDNgyyA/fG44h37lO4HY2b8CrSn6AxBzjZLw0Idq1y
	 Jeeo2M/MGratPZHc4ozQObKhJ6R2E9uawMTmDmmxy8/76BzAPSRYoqbdF6QKTadudz
	 iXOVPGa1+fsvSzegA8noRlvXuvKjwkerAQhX/zKs+q1b0tfStx0qLG0hZqEKViEIbG
	 h/psW0ZIQE1cX/CES6on7/qRt7EpwaeQlXXvSHxWNkK0f2hv0jJF2J60mLDBw1Pqw1
	 mHTTKk5LCsXXfSQQsyGd6YouENjHqPNYQ5TtXfr2bicTgHpYzpDvPnqexALiU6ZUIW
	 NYf1574GlwMmw==
Date: Mon, 9 Dec 2024 13:10:32 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: Christopher Ferris <cferris@google.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>, Kees Cook <kees@kernel.org>,
 "Gustavo A. R. Silva" <gustavo@embeddedor.com>, "Gustavo A. R. Silva"
 <gustavoars@kernel.org>, Michael Chan <michael.chan@broadcom.com>, Andrew
 Lunn <andrew+netdev@lunn.ch>, "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Potnuri
 Bharat Teja <bharat@chelsio.com>, Christian Benvenuti <benve@cisco.com>,
 Satish Kharat <satishkh@cisco.com>, Manish Chopra <manishc@marvell.com>,
 netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-hardening@vger.kernel.org, android-llvm-dev@google.com
Subject: Re: [PATCH v2 1/2][next] UAPI: ethtool: Use __struct_group() in
 struct ethtool_link_settings
Message-ID: <20241209131032.6af473f4@kernel.org>
In-Reply-To: <CANtHk4mnjE5aATk2r8uOsyLKm+7-tbEv5AaXVWGP_unhLNEvsg@mail.gmail.com>
References: <cover.1730238285.git.gustavoars@kernel.org>
	<9e9fb0bd72e5ba1e916acbb4995b1e358b86a689.1730238285.git.gustavoars@kernel.org>
	<20241109100213.262a2fa0@kernel.org>
	<d4f0830f-d384-487a-8442-ca0c603d502b@embeddedor.com>
	<55d62419-3a0c-4f26-a260-06cf2dc44ec1@embeddedor.com>
	<202411151215.B56D49E36@keescook>
	<Z1HZpe3WE5As8UAz@google.com>
	<CANtHk4mnjE5aATk2r8uOsyLKm+7-tbEv5AaXVWGP_unhLNEvsg@mail.gmail.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 9 Dec 2024 12:59:40 -0800 Christopher Ferris wrote:
> It looks like the way this was fixed in the ethtool.h uapi header was to
> revert the usage of __struct_group. Should something similar happen for
> pkt_cls.h? Or would it be easier to simply remove the usage of the TAG in
> the _struct_group macro?

Just to state it explicitly - are you running into a compilation issue
with existing user space after updating pkt_cls.h?