From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DA201DF721; Wed, 11 Dec 2024 01:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733882370; cv=none; b=QWUMV+XTF984aQkE6mS/gw1l/BPGFy6Nqs492vjsUVvK2K9BfUnt/aoqsHuUDucTuxQW2TW0FDYYwhnTCNY3ZpZELG+xAbL55KrCJwm7M3uRBS0l29yZTHT3/fozxOAyuUykL+r9CXNFiwhU4QXjfZ60QEZYxUD4L71fHibGJlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733882370; c=relaxed/simple; bh=zEazvVQelItOcABGIC78+sK4TYpwCtVbuqNNLAXsEQc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=tCpxPccc/zOHbQnUohxSAcwY+QOxlr0OLhsQF6CIg2R98OwCcI8VBQzWo/IBb9J0kOvlO/TTEzx1Ay+RXmRWlwUEhcOuHn+4uvKiuA7pv4POlosqKvafuzcZOiylICj4Kgs6KgpW4JG+Ggnmpp6nlQ+WEwMZTO+s+DcpvbE+xzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WG1789Wz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WG1789Wz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33134C4CED6; Wed, 11 Dec 2024 01:59:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733882369; bh=zEazvVQelItOcABGIC78+sK4TYpwCtVbuqNNLAXsEQc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WG1789WzUIrT/CpBcevHJNOIBumrD1N6Qedrovy+G025hdAW+6EnIYdCcl6WNPWXr rf6QcjjxYtDZD27rljp5BgkVDF13H4WF5weB07ZtroJQFBQHYR4DLq+QY6jvJkiUg+ JAC/Zb945iW1L3wz0RfR61iMWkomZLhzZjDLF5dtzjgLYPUOovWGZBC6F+/OjgldU2 R/kqEAk/RoFGc9lxa+n2mt1GUbo3yp0d6IT60Tb+PQ8xDevuSbsaHKxMIBnRh0L3nq D+TO4pwuz7uDEg1FCcEvgrXHoGee7UYuAAAt1lVHtOlNrWQPSkFqlvD7ESAPTMgZEu tcRetj1RhCpow== Date: Tue, 10 Dec 2024 17:59:28 -0800 From: Jakub Kicinski To: Wei Fang Cc: "andrew@lunn.ch" , "hkallweit1@gmail.com" , "linux@armlinux.org.uk" , "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "florian.fainelli@broadcom.com" , "heiko.stuebner@cherry.de" , "fank.li@nxp.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" Subject: Re: [PATCH v3 net] net: phy: micrel: Dynamically control external clock of KSZ PHY Message-ID: <20241210175928.39505f6c@kernel.org> In-Reply-To: References: <20241206012113.437029-1-wei.fang@nxp.com> <20241209181451.56790483@kernel.org> <20241210164308.6af97d00@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 11 Dec 2024 01:49:50 +0000 Wei Fang wrote: > > I may be missing something but if you don't need to disable the generic > > clock you can put the disable into the if () block for rmii-ref ? > > For my case, it's fine to disable rmii-ref because this clock source is always > enabled in FEC driver. But the commit 99ac4cbcc2a5 ("net: phy: micrel: allow > usage of generic ethernet-phy clock") was applied a year ago, so I raised a > concern in V2 [1], if a new platform only enables rmii-ref in the PHY driver, > disabling rmii-ref after getting the clock rate will cause problem, which will > cause RMII to not work. I'm not sure if any platform actually does this, if so > the following changes will be a more serious problem. Put more of this explanation into the commit message and resend. If it convinces Andrew we can apply.