From: Simon Horman <horms@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: saeedm@nvidia.com, tariqt@nvidia.com, leon@kernel.org,
gal@nvidia.com, kuba@kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org,
Tariq Toukan <ttoukan.linux@gmail.com>
Subject: Re: [PATCH v4 net-next] net/mlx5e: Report rx_discards_phy via rx_dropped
Date: Tue, 10 Dec 2024 19:49:07 +0000 [thread overview]
Message-ID: <20241210194907.GA2806@kernel.org> (raw)
In-Reply-To: <20241210022706.6665-1-laoar.shao@gmail.com>
On Tue, Dec 10, 2024 at 10:27:06AM +0800, Yafang Shao wrote:
> We noticed a high number of rx_discards_phy events on certain servers while
> running `ethtool -S`. However, this critical counter is not currently
> included in the standard /proc/net/dev statistics file, making it difficult
> to monitor effectively—especially given the diversity of vendors across a
> large fleet of servers.
>
> Let's report it via the standard rx_dropped metric.
>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-12-10 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 2:27 [PATCH v4 net-next] net/mlx5e: Report rx_discards_phy via rx_dropped Yafang Shao
2024-12-10 19:49 ` Simon Horman [this message]
2024-12-17 18:45 ` Jakub Kicinski
2024-12-18 6:20 ` Tariq Toukan
2024-12-19 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210194907.GA2806@kernel.org \
--to=horms@kernel.org \
--cc=gal@nvidia.com \
--cc=kuba@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).