From: Simon Horman <horms@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "nikita.yoush" <nikita.yoush@cogentembedded.com>,
Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michael Dege <michael.dege@renesas.com>,
Christian Mardmoeller <christian.mardmoeller@renesas.com>,
Dennis Ostermann <dennis.ostermann@renesas.com>
Subject: Re: [PATCH net] net: renesas: rswitch: fix initial MPIC register setting
Date: Tue, 10 Dec 2024 20:01:15 +0000 [thread overview]
Message-ID: <20241210200115.GC2806@kernel.org> (raw)
In-Reply-To: <TYWPR01MB11030BB4AC02261FF655A13CFD83D2@TYWPR01MB11030.jpnprd01.prod.outlook.com>
On Tue, Dec 10, 2024 at 06:30:41AM +0000, Yoshihiro Shimoda wrote:
> Hello Nikita-san,
>
> > From: Nikita Yushchenko, Sent: Monday, December 9, 2024 5:00 PM
> >
> > MPIC.PIS must be set per phy interface type.
> > MPIC.LSC must be set per speed.
> >
> > Do that strictly per datasheet, instead of hardcoding MPIC.PIS to GMII.
> >
> > Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> > Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
>
> Thank you for the patch! I could not apply this patch on net.git / main branch
> and the branch + your patches [1] though, this patch looks good. So,
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> [1]
> https://patchwork.kernel.org/project/netdevbpf/list/?series=915669
Hi Nikita,
I agree with Shimoda-san that this does not seem to apply cleanly to net.
Which is a requirement for our CI to run. Please rebase and repost.
--
pw-bot: changes-requested
prev parent reply other threads:[~2024-12-10 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 7:59 [PATCH net] net: renesas: rswitch: fix initial MPIC register setting Nikita Yushchenko
2024-12-10 6:30 ` Yoshihiro Shimoda
2024-12-10 20:01 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210200115.GC2806@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=christian.mardmoeller@renesas.com \
--cc=davem@davemloft.net \
--cc=dennis.ostermann@renesas.com \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=michael.dege@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=pabeni@redhat.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).