* [PATCH net-next] gve: Remove unused gve_adminq_set_mtu
@ 2024-12-11 0:19 linux
2024-12-11 3:28 ` Kalesh Anakkur Purayil
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: linux @ 2024-12-11 0:19 UTC (permalink / raw)
To: jeroendb, pkaligineedi, shailend, netdev
Cc: andrew+netdev, davem, edumazet, kuba, pabeni, linux-kernel,
Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
The last use of gve_adminq_set_mtu() was removed by
commit 37149e9374bf ("gve: Implement packet continuation for RX.")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/net/ethernet/google/gve/gve_adminq.c | 14 --------------
drivers/net/ethernet/google/gve/gve_adminq.h | 1 -
2 files changed, 15 deletions(-)
diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/ethernet/google/gve/gve_adminq.c
index 060e0e674938..aa7d723011d0 100644
--- a/drivers/net/ethernet/google/gve/gve_adminq.c
+++ b/drivers/net/ethernet/google/gve/gve_adminq.c
@@ -1128,20 +1128,6 @@ int gve_adminq_unregister_page_list(struct gve_priv *priv, u32 page_list_id)
return gve_adminq_execute_cmd(priv, &cmd);
}
-int gve_adminq_set_mtu(struct gve_priv *priv, u64 mtu)
-{
- union gve_adminq_command cmd;
-
- memset(&cmd, 0, sizeof(cmd));
- cmd.opcode = cpu_to_be32(GVE_ADMINQ_SET_DRIVER_PARAMETER);
- cmd.set_driver_param = (struct gve_adminq_set_driver_parameter) {
- .parameter_type = cpu_to_be32(GVE_SET_PARAM_MTU),
- .parameter_value = cpu_to_be64(mtu),
- };
-
- return gve_adminq_execute_cmd(priv, &cmd);
-}
-
int gve_adminq_report_stats(struct gve_priv *priv, u64 stats_report_len,
dma_addr_t stats_report_addr, u64 interval)
{
diff --git a/drivers/net/ethernet/google/gve/gve_adminq.h b/drivers/net/ethernet/google/gve/gve_adminq.h
index 863683de9694..228217458275 100644
--- a/drivers/net/ethernet/google/gve/gve_adminq.h
+++ b/drivers/net/ethernet/google/gve/gve_adminq.h
@@ -612,7 +612,6 @@ int gve_adminq_destroy_rx_queues(struct gve_priv *priv, u32 queue_id);
int gve_adminq_register_page_list(struct gve_priv *priv,
struct gve_queue_page_list *qpl);
int gve_adminq_unregister_page_list(struct gve_priv *priv, u32 page_list_id);
-int gve_adminq_set_mtu(struct gve_priv *priv, u64 mtu);
int gve_adminq_report_stats(struct gve_priv *priv, u64 stats_report_len,
dma_addr_t stats_report_addr, u64 interval);
int gve_adminq_verify_driver_compatibility(struct gve_priv *priv,
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] gve: Remove unused gve_adminq_set_mtu
2024-12-11 0:19 [PATCH net-next] gve: Remove unused gve_adminq_set_mtu linux
@ 2024-12-11 3:28 ` Kalesh Anakkur Purayil
2024-12-11 16:33 ` Praveen Kaligineedi
2024-12-12 4:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Kalesh Anakkur Purayil @ 2024-12-11 3:28 UTC (permalink / raw)
To: linux
Cc: jeroendb, pkaligineedi, shailend, netdev, andrew+netdev, davem,
edumazet, kuba, pabeni, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 420 bytes --]
On Wed, Dec 11, 2024 at 5:49 AM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The last use of gve_adminq_set_mtu() was removed by
> commit 37149e9374bf ("gve: Implement packet continuation for RX.")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
--
Regards,
Kalesh AP
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4239 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] gve: Remove unused gve_adminq_set_mtu
2024-12-11 0:19 [PATCH net-next] gve: Remove unused gve_adminq_set_mtu linux
2024-12-11 3:28 ` Kalesh Anakkur Purayil
@ 2024-12-11 16:33 ` Praveen Kaligineedi
2024-12-12 4:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Praveen Kaligineedi @ 2024-12-11 16:33 UTC (permalink / raw)
To: linux
Cc: jeroendb, shailend, netdev, andrew+netdev, davem, edumazet, kuba,
pabeni, linux-kernel
On Tue, Dec 10, 2024 at 4:19 PM <linux@treblig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The last use of gve_adminq_set_mtu() was removed by
> commit 37149e9374bf ("gve: Implement packet continuation for RX.")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] gve: Remove unused gve_adminq_set_mtu
2024-12-11 0:19 [PATCH net-next] gve: Remove unused gve_adminq_set_mtu linux
2024-12-11 3:28 ` Kalesh Anakkur Purayil
2024-12-11 16:33 ` Praveen Kaligineedi
@ 2024-12-12 4:20 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-12-12 4:20 UTC (permalink / raw)
To: Dr. David Alan Gilbert
Cc: jeroendb, pkaligineedi, shailend, netdev, andrew+netdev, davem,
edumazet, kuba, pabeni, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 11 Dec 2024 00:19:27 +0000 you wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The last use of gve_adminq_set_mtu() was removed by
> commit 37149e9374bf ("gve: Implement packet continuation for RX.")
>
> Remove it.
>
> [...]
Here is the summary with links:
- [net-next] gve: Remove unused gve_adminq_set_mtu
https://git.kernel.org/netdev/net-next/c/67571036635b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-12 4:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 0:19 [PATCH net-next] gve: Remove unused gve_adminq_set_mtu linux
2024-12-11 3:28 ` Kalesh Anakkur Purayil
2024-12-11 16:33 ` Praveen Kaligineedi
2024-12-12 4:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).