From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Shannon Nelson <shannon.nelson@amd.com>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <brett.creeley@amd.com>
Subject: Re: [PATCH net 1/3] ionic: Fix netdev notifier unregister on failure
Date: Wed, 11 Dec 2024 20:28:40 -0800 [thread overview]
Message-ID: <20241211202840.05c0a461@kernel.org> (raw)
In-Reply-To: <564b9d98-4d64-40ab-a523-4487712430dd@intel.com>
On Tue, 10 Dec 2024 12:59:31 -0800 Jacob Keller wrote:
> I'm not certain about the inclusion of cleanup to drop unused code in
> the same commit as an obvious fix.
+1, please separate the nb_work removal to a net-next commit
--
pw-bot: cr
next prev parent reply other threads:[~2024-12-12 4:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 17:48 [PATCH net 0/3] ionic: minor code fixes Shannon Nelson
2024-12-10 17:48 ` [PATCH net 1/3] ionic: Fix netdev notifier unregister on failure Shannon Nelson
2024-12-10 20:59 ` Jacob Keller
2024-12-12 4:28 ` Jakub Kicinski [this message]
2024-12-12 17:47 ` Nelson, Shannon
2024-12-10 17:48 ` [PATCH net 2/3] ionic: no double destroy workqueue Shannon Nelson
2024-12-10 21:02 ` Jacob Keller
2024-12-10 21:44 ` Nelson, Shannon
2024-12-11 19:23 ` Jacob Keller
2024-12-10 17:48 ` [PATCH net 3/3] ionic: use ee->offset when returning sprom data Shannon Nelson
2024-12-10 21:03 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211202840.05c0a461@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).