From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <salil.mehta@huawei.com>,
<liuyonglong@huawei.com>, <wangpeiyang1@huawei.com>,
<chenhao418@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND net 3/7] net: hns3: Resolved the issue that the debugfs query result is inconsistent.
Date: Fri, 13 Dec 2024 06:10:20 -0800 [thread overview]
Message-ID: <20241213061020.017b6f95@kernel.org> (raw)
In-Reply-To: <1448b4a1-235c-4abe-9f95-fbf6e7f9d640@huawei.com>
On Fri, 13 Dec 2024 21:11:49 +0800 Jijie Shao wrote:
> If the framework does not call .release() for some reason, the buffer
> cannot be freed, causing memory leakage. Maybe it's acceptable？
Are you sure? How did you test?
Looking at the code debugfs itself uses release in a similar way
(u32_array_fops, for example), so I think it should work.
next prev parent reply other threads:[~2024-12-13 14:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 13:30 [PATCH RESEND net 0/7] There are some bugfix for the HNS3 ethernet driver Jijie Shao
2024-11-07 13:30 ` [PATCH RESEND net 1/7] net: hns3: fixed reset failure issues caused by the incorrect reset type Jijie Shao
2024-11-07 13:30 ` [PATCH RESEND net 2/7] net: hns3: fix missing features due to dev->features configuration too early Jijie Shao
2024-11-07 13:30 ` [PATCH RESEND net 3/7] net: hns3: Resolved the issue that the debugfs query result is inconsistent Jijie Shao
2024-11-12 1:25 ` Jakub Kicinski
2024-11-13 5:59 ` Jijie Shao
2024-11-14 0:31 ` Jakub Kicinski
2024-12-09 14:14 ` Jijie Shao
2024-12-09 21:13 ` Jakub Kicinski
2024-12-13 13:11 ` Jijie Shao
2024-12-13 14:10 ` Jakub Kicinski [this message]
2024-11-07 13:30 ` [PATCH RESEND net 4/7] net: hns3: don't auto enable misc vector Jijie Shao
2024-11-07 13:30 ` [PATCH RESEND net 5/7] net: hns3: initialize reset_timer before hclgevf_misc_irq_init() Jijie Shao
2024-11-07 13:30 ` [PATCH RESEND net 6/7] net: hns3: fixed hclge_fetch_pf_reg accesses bar space out of bounds issue Jijie Shao
2024-11-07 13:30 ` [PATCH RESEND net 7/7] net: hns3: fix kernel crash when 1588 is sent on HIP08 devices Jijie Shao
2024-11-12 17:08 ` [PATCH RESEND net 0/7] There are some bugfix for the HNS3 ethernet driver Simon Horman
2024-11-13 3:21 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241213061020.017b6f95@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangpeiyang1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).