netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: linux@treblig.org
To: jes@trained-monkey.org, andrew+netdev@lunn.ch,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, horms@kernel.org
Cc: linux-hippi@sunsite.dk, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev
Date: Sun, 15 Dec 2024 02:26:18 +0000	[thread overview]
Message-ID: <20241215022618.181756-1-linux@treblig.org> (raw)

From: "Dr. David Alan Gilbert" <linux@treblig.org>

hippi_neigh_setup_dev() has been unused since
commit e3804cbebb67 ("net: remove COMPAT_NET_DEV_OPS")

Remove it.

(I'm a little suspicious it's the only setup call removed
by that previous commit?)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/linux/hippidevice.h |  1 -
 net/802/hippi.c             | 15 ---------------
 2 files changed, 16 deletions(-)

diff --git a/include/linux/hippidevice.h b/include/linux/hippidevice.h
index 07414c241e65..404bd5b2b4fc 100644
--- a/include/linux/hippidevice.h
+++ b/include/linux/hippidevice.h
@@ -33,7 +33,6 @@ struct hippi_cb {
 
 __be16 hippi_type_trans(struct sk_buff *skb, struct net_device *dev);
 int hippi_mac_addr(struct net_device *dev, void *p);
-int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p);
 struct net_device *alloc_hippi_dev(int sizeof_priv);
 #endif
 
diff --git a/net/802/hippi.c b/net/802/hippi.c
index 1997b7dd265e..5e02ec1274a1 100644
--- a/net/802/hippi.c
+++ b/net/802/hippi.c
@@ -126,21 +126,6 @@ int hippi_mac_addr(struct net_device *dev, void *p)
 }
 EXPORT_SYMBOL(hippi_mac_addr);
 
-int hippi_neigh_setup_dev(struct net_device *dev, struct neigh_parms *p)
-{
-	/* Never send broadcast/multicast ARP messages */
-	NEIGH_VAR_INIT(p, MCAST_PROBES, 0);
-
-	/* In IPv6 unicast probes are valid even on NBMA,
-	* because they are encapsulated in normal IPv6 protocol.
-	* Should be a generic flag.
-	*/
-	if (p->tbl->family != AF_INET6)
-		NEIGH_VAR_INIT(p, UCAST_PROBES, 0);
-	return 0;
-}
-EXPORT_SYMBOL(hippi_neigh_setup_dev);
-
 static const struct header_ops hippi_header_ops = {
 	.create		= hippi_header,
 };
-- 
2.47.1


             reply	other threads:[~2024-12-15  2:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-15  2:26 linux [this message]
2024-12-15  2:28 ` [PATCH net-next] hippi: Remove unused hippi_neigh_setup_dev Dr. David Alan Gilbert
2024-12-16 16:14   ` Simon Horman
2024-12-16 16:56     ` Dr. David Alan Gilbert
2024-12-16 16:12 ` Simon Horman
2024-12-16 16:48   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241215022618.181756-1-linux@treblig.org \
    --to=linux@treblig.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jes@trained-monkey.org \
    --cc=kuba@kernel.org \
    --cc=linux-hippi@sunsite.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).