From: Jakub Kicinski <kuba@kernel.org>
To: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Cc: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/7] mptcp: add mptcp_userspace_pm_get_sock helper
Date: Sun, 15 Dec 2024 14:32:08 -0800 [thread overview]
Message-ID: <20241215143208.3786c360@kernel.org> (raw)
In-Reply-To: <20241213-net-next-mptcp-pm-misc-cleanup-v1-3-ddb6d00109a8@kernel.org>
On Fri, 13 Dec 2024 20:52:54 +0100 Matthieu Baerts (NGI0) wrote:
> struct nlattr *token = info->attrs[MPTCP_PM_ATTR_TOKEN];
> + struct mptcp_sock *msk;
> +
> + if (!token) {
> + GENL_SET_ERR_MSG(info, "missing required token");
> + return NULL;
> + }
Ideally GENL_REQ_ATTR_CHECK() would be used in such cases.
next prev parent reply other threads:[~2024-12-15 22:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 19:52 [PATCH net-next 0/7] mptcp: pm: userspace: misc cleanups Matthieu Baerts (NGI0)
2024-12-13 19:52 ` [PATCH net-next 1/7] mptcp: add mptcp_userspace_pm_lookup_addr helper Matthieu Baerts (NGI0)
2024-12-13 19:52 ` [PATCH net-next 2/7] mptcp: add mptcp_for_each_userspace_pm_addr macro Matthieu Baerts (NGI0)
2024-12-13 19:52 ` [PATCH net-next 3/7] mptcp: add mptcp_userspace_pm_get_sock helper Matthieu Baerts (NGI0)
2024-12-15 22:32 ` Jakub Kicinski [this message]
2024-12-13 19:52 ` [PATCH net-next 4/7] mptcp: move mptcp_pm_remove_addrs into pm_userspace Matthieu Baerts (NGI0)
2024-12-13 19:52 ` [PATCH net-next 5/7] mptcp: drop free_list for deleting entries Matthieu Baerts (NGI0)
2024-12-13 19:52 ` [PATCH net-next 6/7] mptcp: change local addr type of subflow_destroy Matthieu Baerts (NGI0)
2024-12-13 19:52 ` [PATCH net-next 7/7] mptcp: drop useless "err = 0" in subflow_destroy Matthieu Baerts (NGI0)
2024-12-15 22:40 ` [PATCH net-next 0/7] mptcp: pm: userspace: misc cleanups patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241215143208.3786c360@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).