From: Vladimir Oltean <olteanv@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christian Marangi <ansuelsmth@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: qca8k: Fix inconsistent use of jiffies vs milliseconds
Date: Mon, 16 Dec 2024 01:13:34 +0200 [thread overview]
Message-ID: <20241215231334.imva5oorpyq7lavl@skbuf> (raw)
In-Reply-To: <20241215-qca8k-jiffies-v1-1-5a4d313c76ea@lunn.ch>
On Sun, Dec 15, 2024 at 05:43:55PM +0000, Andrew Lunn wrote:
> wait_for_complete_timeout() expects a timeout in jiffies. With the
> driver, some call sites converted QCA8K_ETHERNET_TIMEOUT to jiffies,
> others did not. Make the code consistent by changes the #define to
> include a call to msecs_to_jiffies, and remove all other calls to
> msecs_to_jiffies.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
If my calculations are correct, for CONFIG_HZ=100, 5 jiffies last 50 ms.
So, assuming that configuration, the patch would be _decreasing_ the timeout
from 50 ms to 5 ms. The change should be tested to confirm it's enough.
Christian, could you do that?
next prev parent reply other threads:[~2024-12-15 23:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-15 17:43 [PATCH net-next] net: dsa: qca8k: Fix inconsistent use of jiffies vs milliseconds Andrew Lunn
2024-12-15 23:13 ` Vladimir Oltean [this message]
2024-12-16 9:21 ` Andrew Lunn
2024-12-16 19:55 ` Christian Marangi
2024-12-16 23:08 ` Andrew Lunn
2024-12-18 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241215231334.imva5oorpyq7lavl@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox