Re: [PATCH v2 2/4] dt-bindings: mfd: Add MDIO interface to rtl9301-switch

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

On Mon, Dec 16, 2024 at 04:13:44PM +1300, Chris Packham wrote:
> The MDIO controller is part of the switch on the RTL9300 family of
> devices. Add a $ref to the mfd binding for these devices.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> 
> Notes:
>     Changes in v2:
>     - None
> 
>  .../bindings/mfd/realtek,rtl9301-switch.yaml      | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> index f053303ab1e6..eeb08e7435fa 100644
> --- a/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> +++ b/Documentation/devicetree/bindings/mfd/realtek,rtl9301-switch.yaml
> @@ -41,6 +41,9 @@ patternProperties:
>    'i2c@[0-9a-f]+$':
>      $ref: /schemas/i2c/realtek,rtl9301-i2c.yaml#
>  
> +  'mdio@[0-9a-f]+$':
> +    $ref: /schemas/net/realtek,rtl9301-mdio.yaml#
> +
>  required:
>    - compatible
>    - reg
> @@ -110,5 +113,17 @@ examples:
>            };
>          };
>        };
> +
> +      mdio0: mdio@ca00 {

Label here is unused, but that alone isn't worth a respin.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> +        compatible = "realtek,rtl9301-mdio";
> +        reg = <0xca00 0x200>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet-phy@0 {
> +          reg = <0>;
> +          realtek,smi-address = <0 1>;
> +        };
> +      };
>      };
>  
> -- 
> 2.47.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]