From: Jakub Kicinski <kuba@kernel.org>
To: Li Li <dualli@chromium.org>
Cc: Carlos Llamas <cmllamas@google.com>,
dualli@google.com, corbet@lwn.net, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com, donald.hunter@gmail.com,
gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, joel@joelfernandes.org, brauner@kernel.org,
surenb@google.com, arnd@arndb.de, masahiroy@kernel.org,
bagasdotme@gmail.com, horms@kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
netdev@vger.kernel.org, hridya@google.com, smoreland@google.com,
kernel-team@android.com
Subject: Re: [PATCH net-next v10 2/2] binder: report txn errors via generic netlink
Date: Mon, 16 Dec 2024 17:41:11 -0800 [thread overview]
Message-ID: <20241216174111.3fdce872@kernel.org> (raw)
In-Reply-To: <CANBPYPhZ-_5=VMRoBxbfVb+AFb_qu49QH_hKOiSjX93E1GQA8A@mail.gmail.com>
On Mon, 16 Dec 2024 10:58:10 -0800 Li Li wrote:
> > not: There are several places where you have "netlink_nl" which seems
> > kind of redundant to me. wdyt? IMO you should drop the "nl" in all of
> > these cases.
> >
>
> These are automatically generated from the yaml file. So let's just
> keep them as is.
> But it's a good suggestion to the owner of yaml parser.
I think the unusual naming comes from fact that you call your netlink
family binder_netlink. It's sort of like adding the word sysfs to the
name of a sysfs file. I mean the user visible name, not code
references...
s/binder_netlink/binder/ will clean this up..
next prev parent reply other threads:[~2024-12-17 1:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 22:41 [PATCH net-next v10 0/2] binder: report txn errors via generic netlink Li Li
2024-12-12 22:41 ` [PATCH net-next v10 1/2] binderfs: add new binder devices to binder_devices Li Li
2024-12-15 22:27 ` Jakub Kicinski
2024-12-16 5:06 ` Li Li
2024-12-16 18:01 ` Carlos Llamas
2024-12-12 22:41 ` [PATCH net-next v10 2/2] binder: report txn errors via generic netlink Li Li
2024-12-16 18:12 ` Carlos Llamas
2024-12-16 18:58 ` Li Li
2024-12-17 1:41 ` Jakub Kicinski [this message]
2024-12-17 3:53 ` Li Li
2024-12-17 14:51 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241216174111.3fdce872@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=bagasdotme@gmail.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dualli@chromium.org \
--cc=dualli@google.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@kernel.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=masahiroy@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=smoreland@google.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).