From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Markus Schneider-Pargmann <msp@baylibre.com>
Subject: Re: [PATCH net 2/2] can: m_can: fix missed interrupts with m_can_pci
Date: Wed, 18 Dec 2024 17:51:08 -0800 [thread overview]
Message-ID: <20241218175108.39f6f79e@kernel.org> (raw)
In-Reply-To: <20241218121722.2311963-3-mkl@pengutronix.de>
On Wed, 18 Dec 2024 13:10:28 +0100 Marc Kleine-Budde wrote:
> + while ((ir_read = m_can_read(cdev, M_CAN_IR)) != 0) {
> + ir |= ir_read;
> +
> + /* ACK all irqs */
> + m_can_write(cdev, M_CAN_IR, ir);
Perhaps consider adding a cap on how many times this can loop
as a follow up? Maybe if the HW is bad all bets are off, anyway,
but potential infinite loop inside an IRQ feels a little scary.
next prev parent reply other threads:[~2024-12-19 1:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 12:10 [PATCH net 0/2] pull-request: can 2024-12-18 Marc Kleine-Budde
2024-12-18 12:10 ` [PATCH net 1/2] can: m_can: set init flag earlier in probe Marc Kleine-Budde
2024-12-19 2:00 ` patchwork-bot+netdevbpf
2024-12-18 12:10 ` [PATCH net 2/2] can: m_can: fix missed interrupts with m_can_pci Marc Kleine-Budde
2024-12-19 1:51 ` Jakub Kicinski [this message]
2024-12-19 1:54 ` [PATCH net 0/2] pull-request: can 2024-12-18 Jakub Kicinski
2024-12-19 8:03 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218175108.39f6f79e@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=mkl@pengutronix.de \
--cc=msp@baylibre.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).