From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Tony Lindgren <tony@atomide.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
linux-omap@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 1/3] net: phy: add phy_disable_eee
Date: Wed, 18 Dec 2024 18:59:09 -0800 [thread overview]
Message-ID: <20241218185909.363b9dfc@kernel.org> (raw)
In-Reply-To: <35e1ded5-e33f-4ea4-ab16-c460da402822@lunn.ch>
On Tue, 17 Dec 2024 11:43:11 +0100 Andrew Lunn wrote:
> > @@ -2071,6 +2071,7 @@ void phy_advertise_eee_all(struct phy_device *phydev);
> > void phy_support_sym_pause(struct phy_device *phydev);
> > void phy_support_asym_pause(struct phy_device *phydev);
> > void phy_support_eee(struct phy_device *phydev);
> > +void phy_disable_eee(struct phy_device *phydev);
>
> So we have three states:
>
> MAC tells PHYLIB it does support EEE
> MAC tells PHYLIB it does not support EEE
> MAC says nothing.
>
> Do we really want this?
Hi Andrew, do you feel convinced? I think I messed up merging some EEE
patches recently, an explicit Ack would boost my confidence..
next prev parent reply other threads:[~2024-12-19 2:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 21:29 [PATCH net-next 0/3] net: add and use phy_disable_eee Heiner Kallweit
2024-12-16 21:31 ` [PATCH net-next 1/3] net: phy: add phy_disable_eee Heiner Kallweit
2024-12-17 10:43 ` Andrew Lunn
2024-12-17 20:50 ` Heiner Kallweit
2024-12-17 22:34 ` Andrew Lunn
2024-12-18 7:01 ` Heiner Kallweit
2024-12-19 2:59 ` Jakub Kicinski [this message]
2024-12-19 8:41 ` Andrew Lunn
2024-12-19 8:34 ` Andrew Lunn
2024-12-16 21:32 ` [PATCH net-next 2/3] net: ethernet: ti: cpsw: disable PHY EEE advertisement Heiner Kallweit
2024-12-19 8:34 ` Andrew Lunn
2024-12-16 21:33 ` [PATCH net-next 3/3] ARM: dts: ti/omap: remove eee-broken properties Heiner Kallweit
2024-12-19 8:35 ` Andrew Lunn
2024-12-20 3:30 ` [PATCH net-next 0/3] net: add and use phy_disable_eee patchwork-bot+netdevbpf
2024-12-20 8:26 ` Heiner Kallweit
2024-12-20 8:40 ` Andrew Lunn
2024-12-20 14:25 ` Jakub Kicinski
2024-12-20 22:14 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241218185909.363b9dfc@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).