From: kernel test robot <lkp@intel.com>
To: Ahmed Zaki <ahmed.zaki@intel.com>, netdev@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
intel-wired-lan@lists.osuosl.org, andrew+netdev@lunn.ch,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
davem@davemloft.net, michael.chan@broadcom.com,
tariqt@nvidia.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, jdamato@fastly.com,
shayd@nvidia.com, akpm@linux-foundation.org,
Ahmed Zaki <ahmed.zaki@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 4/8] net: napi: add CPU affinity to napi->config
Date: Thu, 19 Dec 2024 04:27:17 +0800 [thread overview]
Message-ID: <202412190454.nwvp3hU2-lkp@intel.com> (raw)
In-Reply-To: <20241218165843.744647-5-ahmed.zaki@intel.com>
Hi Ahmed,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Ahmed-Zaki/net-napi-add-irq_flags-to-napi-struct/20241219-010125
base: net-next/main
patch link: https://lore.kernel.org/r/20241218165843.744647-5-ahmed.zaki%40intel.com
patch subject: [Intel-wired-lan] [PATCH net-next v2 4/8] net: napi: add CPU affinity to napi->config
config: riscv-randconfig-001-20241219 (https://download.01.org/0day-ci/archive/20241219/202412190454.nwvp3hU2-lkp@intel.com/config)
compiler: clang version 16.0.6 (https://github.com/llvm/llvm-project 7cbf1a2591520c2491aa35339f227775f4d3adf6)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241219/202412190454.nwvp3hU2-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412190454.nwvp3hU2-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/core/dev.c:6755:7: warning: variable 'glue_created' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
if (rc) {
^~
net/core/dev.c:6766:7: note: uninitialized use occurs here
if (!glue_created && flags & NAPIF_IRQ_AFFINITY) {
^~~~~~~~~~~~
net/core/dev.c:6755:3: note: remove the 'if' if its condition is always false
if (rc) {
^~~~~~~~~
>> net/core/dev.c:6752:6: warning: variable 'glue_created' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (napi->dev->rx_cpu_rmap && flags & NAPIF_IRQ_ARFS_RMAP) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:6766:7: note: uninitialized use occurs here
if (!glue_created && flags & NAPIF_IRQ_AFFINITY) {
^~~~~~~~~~~~
net/core/dev.c:6752:2: note: remove the 'if' if its condition is always true
if (napi->dev->rx_cpu_rmap && flags & NAPIF_IRQ_ARFS_RMAP) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net/core/dev.c:6752:6: warning: variable 'glue_created' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
if (napi->dev->rx_cpu_rmap && flags & NAPIF_IRQ_ARFS_RMAP) {
^~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:6766:7: note: uninitialized use occurs here
if (!glue_created && flags & NAPIF_IRQ_AFFINITY) {
^~~~~~~~~~~~
net/core/dev.c:6752:6: note: remove the '&&' if its condition is always true
if (napi->dev->rx_cpu_rmap && flags & NAPIF_IRQ_ARFS_RMAP) {
^~~~~~~~~~~~~~~~~~~~~~~~~
net/core/dev.c:6745:19: note: initialize the variable 'glue_created' to silence this warning
bool glue_created;
^
= 0
net/core/dev.c:4176:1: warning: unused function 'sch_handle_ingress' [-Wunused-function]
sch_handle_ingress(struct sk_buff *skb, struct packet_type **pt_prev, int *ret,
^
net/core/dev.c:4183:1: warning: unused function 'sch_handle_egress' [-Wunused-function]
sch_handle_egress(struct sk_buff *skb, int *ret, struct net_device *dev)
^
net/core/dev.c:5440:19: warning: unused function 'nf_ingress' [-Wunused-function]
static inline int nf_ingress(struct sk_buff *skb, struct packet_type **pt_prev,
^
6 warnings generated.
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FB_IOMEM_HELPERS
Depends on [n]: HAS_IOMEM [=y] && FB_CORE [=n]
Selected by [m]:
- DRM_XE_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=m] && DRM_XE [=m] && DRM_XE [=m]=m [=m] && HAS_IOPORT [=y]
vim +6755 net/core/dev.c
8e5191fb19bffce Ahmed Zaki 2024-12-18 6741
001dc6db21f4bfe Ahmed Zaki 2024-12-18 6742 void netif_napi_set_irq(struct napi_struct *napi, int irq, unsigned long flags)
001dc6db21f4bfe Ahmed Zaki 2024-12-18 6743 {
8e5191fb19bffce Ahmed Zaki 2024-12-18 6744 struct irq_glue *glue = NULL;
8e5191fb19bffce Ahmed Zaki 2024-12-18 6745 bool glue_created;
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6746 int rc;
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6747
001dc6db21f4bfe Ahmed Zaki 2024-12-18 6748 napi->irq = irq;
001dc6db21f4bfe Ahmed Zaki 2024-12-18 6749 napi->irq_flags = flags;
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6750
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6751 #ifdef CONFIG_RFS_ACCEL
a274d2669a73ef7 Ahmed Zaki 2024-12-18 @6752 if (napi->dev->rx_cpu_rmap && flags & NAPIF_IRQ_ARFS_RMAP) {
8e5191fb19bffce Ahmed Zaki 2024-12-18 6753 rc = irq_cpu_rmap_add(napi->dev->rx_cpu_rmap, irq, napi,
8e5191fb19bffce Ahmed Zaki 2024-12-18 6754 netif_irq_cpu_rmap_notify);
a274d2669a73ef7 Ahmed Zaki 2024-12-18 @6755 if (rc) {
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6756 netdev_warn(napi->dev, "Unable to update ARFS map (%d).\n",
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6757 rc);
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6758 free_irq_cpu_rmap(napi->dev->rx_cpu_rmap);
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6759 napi->dev->rx_cpu_rmap = NULL;
8e5191fb19bffce Ahmed Zaki 2024-12-18 6760 } else {
8e5191fb19bffce Ahmed Zaki 2024-12-18 6761 glue_created = true;
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6762 }
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6763 }
a274d2669a73ef7 Ahmed Zaki 2024-12-18 6764 #endif
8e5191fb19bffce Ahmed Zaki 2024-12-18 6765
8e5191fb19bffce Ahmed Zaki 2024-12-18 6766 if (!glue_created && flags & NAPIF_IRQ_AFFINITY) {
8e5191fb19bffce Ahmed Zaki 2024-12-18 6767 glue = kzalloc(sizeof(*glue), GFP_KERNEL);
8e5191fb19bffce Ahmed Zaki 2024-12-18 6768 if (!glue)
8e5191fb19bffce Ahmed Zaki 2024-12-18 6769 return;
8e5191fb19bffce Ahmed Zaki 2024-12-18 6770 glue->notify.notify = netif_irq_cpu_rmap_notify;
8e5191fb19bffce Ahmed Zaki 2024-12-18 6771 glue->notify.release = netif_napi_affinity_release;
8e5191fb19bffce Ahmed Zaki 2024-12-18 6772 glue->data = napi;
8e5191fb19bffce Ahmed Zaki 2024-12-18 6773 glue->rmap = NULL;
8e5191fb19bffce Ahmed Zaki 2024-12-18 6774 napi->irq_flags |= NAPIF_IRQ_NORMAP;
8e5191fb19bffce Ahmed Zaki 2024-12-18 6775 }
001dc6db21f4bfe Ahmed Zaki 2024-12-18 6776 }
001dc6db21f4bfe Ahmed Zaki 2024-12-18 6777 EXPORT_SYMBOL(netif_napi_set_irq);
001dc6db21f4bfe Ahmed Zaki 2024-12-18 6778
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-12-18 20:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 16:58 [PATCH net-next v2 0/8] net: napi: add CPU affinity to napi->config Ahmed Zaki
2024-12-18 16:58 ` [PATCH net-next v2 1/8] net: napi: add irq_flags to napi struct Ahmed Zaki
2024-12-20 3:34 ` Jakub Kicinski
2024-12-20 14:50 ` Ahmed Zaki
2024-12-18 16:58 ` [PATCH net-next v2 2/8] net: allow ARFS rmap management in core Ahmed Zaki
2024-12-18 19:56 ` [Intel-wired-lan] " kernel test robot
2024-12-18 16:58 ` [PATCH net-next v2 3/8] lib: cpu_rmap: allow passing a notifier callback Ahmed Zaki
2024-12-18 16:58 ` [PATCH net-next v2 4/8] net: napi: add CPU affinity to napi->config Ahmed Zaki
2024-12-18 20:16 ` [Intel-wired-lan] " kernel test robot
2024-12-18 20:27 ` kernel test robot [this message]
2024-12-20 3:42 ` Jakub Kicinski
2024-12-20 14:51 ` Ahmed Zaki
2024-12-20 17:23 ` Jakub Kicinski
2024-12-20 19:15 ` Ahmed Zaki
2024-12-20 19:37 ` Jakub Kicinski
2024-12-20 20:14 ` Ahmed Zaki
2024-12-20 20:51 ` Jakub Kicinski
2024-12-18 16:58 ` [PATCH net-next v2 5/8] bnxt: use napi's irq affinity Ahmed Zaki
2024-12-18 16:58 ` [PATCH net-next v2 6/8] ice: " Ahmed Zaki
2024-12-18 16:58 ` [PATCH net-next v2 7/8] idpf: " Ahmed Zaki
2024-12-18 16:58 ` [PATCH net-next v2 8/8] mlx4: " Ahmed Zaki
2024-12-22 9:23 ` [PATCH net-next v2 0/8] net: napi: add CPU affinity to napi->config Shay Drori
2025-01-02 21:38 ` Ahmed Zaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412190454.nwvp3hU2-lkp@intel.com \
--to=lkp@intel.com \
--cc=ahmed.zaki@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=llvm@lists.linux.dev \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).