From: Jakub Kicinski <kuba@kernel.org>
To: Guowei Dang <guowei.dang@foxmail.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
netdev@vger.kernel.org, Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Yunsheng Lin <linyunsheng@huawei.com>,
Furong Xu <0x1207@gmail.com>
Subject: Re: [PATCH net-next v1] net: page_pool: add page_pool_put_page_nosync()
Date: Thu, 19 Dec 2024 06:24:38 -0800 [thread overview]
Message-ID: <20241219062438.1c89b98b@kernel.org> (raw)
In-Reply-To: <tencent_76E62F6A47A7C7E818FC7C74A6B02772F308@qq.com>
On Thu, 19 Dec 2024 11:11:38 +0800 Guowei Dang wrote:
> Add page_pool_put_page_nosync() to respond to dma_sync_size being 0.
>
> The purpose of this is to make the semantics more obvious and may
> enable removing some checkings in the future.
>
> And in the long term, treating the nosync scenario separately provides
> more flexibility for the user and enable removing of the
> PP_FLAG_DMA_SYNC_DEV in the future.
>
> Since we do have a page_pool_put_full_page(), adding a variant for
> the nosync seems reasonable.
You should provide an upstream user with the API.
But IMHO this just complicates the already very large API,
for little benefit.
I'm going to leave this in patchwork for a day in case page
pool maintainers disagree, but I vote "no".
next prev parent reply other threads:[~2024-12-19 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 3:11 [PATCH net-next v1] net: page_pool: add page_pool_put_page_nosync() Guowei Dang
2024-12-19 12:46 ` Yunsheng Lin
2024-12-19 14:24 ` Jakub Kicinski [this message]
2024-12-19 16:01 ` Alexander Lobakin
2024-12-20 12:27 ` Ilias Apalodimas
2024-12-20 15:49 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219062438.1c89b98b@kernel.org \
--to=kuba@kernel.org \
--cc=0x1207@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guowei.dang@foxmail.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).