From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: martin.lau@linux.dev, razor@blackwall.org, pabeni@redhat.com,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next 1/3] netkit: Allow for configuring needed_{head,tail}room
Date: Thu, 19 Dec 2024 18:23:24 -0800 [thread overview]
Message-ID: <20241219182324.4707e425@kernel.org> (raw)
In-Reply-To: <20241219173928.464437-1-daniel@iogearbox.net>
On Thu, 19 Dec 2024 18:39:26 +0100 Daniel Borkmann wrote:
> + if (headroom) {
> + peer->needed_headroom = headroom;
> + dev->needed_headroom = headroom;
> + }
> + if (tailroom) {
> + peer->needed_tailroom = tailroom;
> + dev->needed_tailroom = tailroom;
> + }
Since you use the same one for main dev and peer should there be
something rejecting the use of the new attr in the peer attrs?
(IFLA_NETKIT_PEER_INFO)
> + struct {
static const?
I wish more userspace learned how to do reverse parsing.
We wouldn't have to bother injecting the attr names to all the messages,
NL_SET_ERR_MSG_ATTR() already points to the attr :|
next prev parent reply other threads:[~2024-12-20 2:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 17:39 [PATCH bpf-next 1/3] netkit: Allow for configuring needed_{head,tail}room Daniel Borkmann
2024-12-19 17:39 ` [PATCH bpf-next 2/3] netkit: Add add netkit {head,tail}room to rt_link.yaml Daniel Borkmann
2024-12-21 7:22 ` Nikolay Aleksandrov
2024-12-19 17:39 ` [PATCH bpf-next 3/3] selftests/bpf: Extend netkit tests to validate set {head,tail}room Daniel Borkmann
2024-12-21 7:22 ` Nikolay Aleksandrov
2024-12-20 2:23 ` Jakub Kicinski [this message]
2024-12-20 9:06 ` [PATCH bpf-next 1/3] netkit: Allow for configuring needed_{head,tail}room Daniel Borkmann
2024-12-21 0:04 ` Daniel Borkmann
2024-12-21 7:22 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219182324.4707e425@kernel.org \
--to=kuba@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).