Re: [PATCH net 4/4] net/mlx5e: Keep netdev when leave switchdev for devlink set legacy only

[Jakub Kicinski <kuba@kernel.org>]

On Fri, 20 Dec 2024 09:48:11 +0100 Przemek Kitszel wrote:
> >   	mlx5_core_uplink_netdev_set(mdev, NULL);
> >   	mlx5e_dcbnl_delete_app(priv);
> > -	unregister_netdev(priv->netdev);
> > -	_mlx5e_suspend(adev, false);
> > +	/* When unload driver, the netdev is in registered state  
> 
> /*
>   * Netdev dropped the special comment allowance rule,
>   * now you have to put one line almost blank at the front.
>   */

Incorrect, we still prefer the old comment style, we just give a pass 
now to people who have a strong preference the opposite way.

> > +	 * if it's from legacy mode. If from switchdev mode, it
> > +	 * is already unregistered before changing to NIC profile.
> > +	 */
> > +	if (priv->netdev->reg_state == NETREG_REGISTERED) {
> > +		unregister_netdev(priv->netdev);
> > +		_mlx5e_suspend(adev, false);
> > +	} else {
> > +		struct mlx5_core_dev *pos;
> > +		int i;
> > +
> > +		if (test_bit(MLX5E_STATE_DESTROYING, &priv->state))  
> 
> you have more than one statement/expression inside the if,
> so you must wrap with braces

I'm not aware of that as a hard rule either.