From: Jakub Kicinski <kuba@kernel.org>
To: Lei Wei <quic_leiwei@quicinc.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <quic_kkumarcs@quicinc.com>,
<quic_suruchia@quicinc.com>, <quic_pavir@quicinc.com>,
<quic_linchen@quicinc.com>, <quic_luoj@quicinc.com>,
<srinivas.kandagatla@linaro.org>,
<bartosz.golaszewski@linaro.org>, <vsmuthu@qti.qualcomm.com>,
<john@phrozen.org>
Subject: Re: [PATCH net-next v3 4/5] net: pcs: qcom-ipq9574: Add USXGMII interface mode support
Date: Fri, 20 Dec 2024 13:49:41 -0800 [thread overview]
Message-ID: <20241220134941.370d3357@kernel.org> (raw)
In-Reply-To: <20241216-ipq_pcs_6-13_rc1-v3-4-3abefda0fc48@quicinc.com>
On Mon, 16 Dec 2024 21:40:26 +0800 Lei Wei wrote:
> +static int ipq_pcs_config_usxgmii(struct ipq_pcs *qpcs)
> +{
> + int ret;
> +
> + /* Configure the XPCS for USXGMII mode if required */
> + if (qpcs->interface != PHY_INTERFACE_MODE_USXGMII) {
nit:
if (qpcs->interface == PHY_INTERFACE_MODE_USXGMII)
return 0;
And then the entire function doesn't have to be indented.
Please fix this and repost, it'd be great to get a review tag from
Russell or someone with more phylink knowledge.. Please be mindful of:
https://lore.kernel.org/all/20241211164022.6a075d3a@kernel.org/
--
pw-bot: cr
next prev parent reply other threads:[~2024-12-20 21:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 13:40 [PATCH net-next v3 0/5] Add PCS support for Qualcomm IPQ9574 SoC Lei Wei
2024-12-16 13:40 ` [PATCH net-next v3 1/5] dt-bindings: net: pcs: Add Ethernet PCS " Lei Wei
2024-12-22 8:20 ` Krzysztof Kozlowski
2024-12-25 13:49 ` Lei Wei
2024-12-16 13:40 ` [PATCH net-next v3 2/5] net: pcs: Add PCS driver " Lei Wei
2024-12-23 23:22 ` kernel test robot
2024-12-16 13:40 ` [PATCH net-next v3 3/5] net: pcs: qcom-ipq9574: Add PCS instantiation and phylink operations Lei Wei
2024-12-24 6:59 ` Manikanta Mylavarapu
2024-12-24 7:15 ` Dmitry Baryshkov
2024-12-24 9:16 ` Manikanta Mylavarapu
2024-12-24 15:41 ` Andrew Lunn
2025-01-02 10:54 ` Russell King (Oracle)
2025-01-03 10:14 ` Lei Wei
2024-12-16 13:40 ` [PATCH net-next v3 4/5] net: pcs: qcom-ipq9574: Add USXGMII interface mode support Lei Wei
2024-12-20 21:49 ` Jakub Kicinski [this message]
2024-12-25 13:47 ` Lei Wei
2024-12-16 13:40 ` [PATCH net-next v3 5/5] MAINTAINERS: Add maintainer for Qualcomm IPQ9574 PCS driver Lei Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241220134941.370d3357@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vsmuthu@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).