From: Jakub Kicinski <kuba@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 26/29] net/tls: use the new scatterwalk functions
Date: Mon, 23 Dec 2024 07:48:25 -0800 [thread overview]
Message-ID: <20241223074825.7c4c74a0@kernel.org> (raw)
In-Reply-To: <20241221091056.282098-27-ebiggers@kernel.org>
On Sat, 21 Dec 2024 01:10:53 -0800 Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Replace calls to the deprecated function scatterwalk_copychunks() with
> memcpy_from_scatterwalk(), memcpy_to_scatterwalk(), or
> scatterwalk_skip() as appropriate.
>
> The new functions behave more as expected and eliminate the need to call
> scatterwalk_done() or scatterwalk_pagedone(). This was not always being
> done when needed, and therefore the old code appears to have also had a
> bug where the dcache of the destination page(s) was not always being
> flushed on architectures that need that.
>
> Cc: Boris Pismenny <borisp@nvidia.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2024-12-23 15:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241221091056.282098-1-ebiggers@kernel.org>
2024-12-21 9:10 ` [PATCH 26/29] net/tls: use the new scatterwalk functions Eric Biggers
2024-12-23 15:48 ` Jakub Kicinski [this message]
2024-12-23 19:42 ` Eric Biggers
2024-12-23 20:44 ` Jakub Kicinski
2024-12-29 23:58 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223074825.7c4c74a0@kernel.org \
--to=kuba@kernel.org \
--cc=borisp@nvidia.com \
--cc=ebiggers@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).