From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"Rongwei Liu" <rongweil@nvidia.com>
Subject: Re: [PATCH net-next V4 01/11] net/mlx5: LAG, Refactor lag logic
Date: Mon, 23 Dec 2024 10:32:01 -0800 [thread overview]
Message-ID: <20241223103201.65a46a7a@kernel.org> (raw)
In-Reply-To: <20241219175841.1094544-2-tariqt@nvidia.com>
On Thu, 19 Dec 2024 19:58:31 +0200 Tariq Toukan wrote:
> @@ -88,13 +86,13 @@ static int mlx5_lag_create_port_sel_table(struct mlx5_lag *ldev,
> &dest, 1);
> if (IS_ERR(lag_definer->rules[idx])) {
> err = PTR_ERR(lag_definer->rules[idx]);
> - do {
> + mlx5_ldev_for_each_reverse(k, i, 0, ldev) {
> while (j--) {
> - idx = i * ldev->buckets + j;
> + idx = k * ldev->buckets + j;
> mlx5_del_flow_rules(lag_definer->rules[idx]);
> }
> j = ldev->buckets;
> - } while (i--);
> + };
stray semicolon, please follow up
> goto destroy_fg;
> }
next prev parent reply other threads:[~2024-12-23 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 17:58 [PATCH net-next V4 00/11] mlx5 misc changes 2024-12-19 Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 01/11] net/mlx5: LAG, Refactor lag logic Tariq Toukan
2024-12-23 18:32 ` Jakub Kicinski [this message]
2024-12-19 17:58 ` [PATCH net-next V4 02/11] net/mlx5: LAG, Support LAG over Multi-Host NICs Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 03/11] net/mlx5: fs, add counter object to flow destination Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 04/11] net/mlx5: fs, add mlx5_fs_pool API Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 05/11] net/mlx5: fs, retry insertion to hash table on EBUSY Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 06/11] net/mlx5: HWS, no need to expose mlx5hws_send_queues_open/close Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 07/11] net/mlx5: HWS, do not initialize native API queues Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 08/11] net/mlx5: DR, expand SWS STE callbacks and consolidate common structs Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 09/11] net/mlx5: DR, add support for ConnectX-8 steering Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 10/11] net/mlx5: Remove PTM support log message Tariq Toukan
2024-12-19 17:58 ` [PATCH net-next V4 11/11] net/mlx5: fs, Add support for RDMA RX steering over IB link layer Tariq Toukan
2024-12-23 18:40 ` [PATCH net-next V4 00/11] mlx5 misc changes 2024-12-19 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241223103201.65a46a7a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leonro@nvidia.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rongweil@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).